From ac43a0a104bc736d2535f0efde1508c87bc00b4e Mon Sep 17 00:00:00 2001 From: rkaldung Date: Thu, 12 Feb 2015 20:26:30 +0100 Subject: [PATCH] using constants instead of literals --- app/controllers/ticket_states_controller.rb | 6 +++--- config/initializers/zammad_constants.rb | 7 +++++++ 2 files changed, 10 insertions(+), 3 deletions(-) create mode 100644 config/initializers/zammad_constants.rb diff --git a/app/controllers/ticket_states_controller.rb b/app/controllers/ticket_states_controller.rb index 60bf20de8..61fd71678 100644 --- a/app/controllers/ticket_states_controller.rb +++ b/app/controllers/ticket_states_controller.rb @@ -15,19 +15,19 @@ class TicketStatesController < ApplicationController # POST /ticket_states def create - return if deny_if_not_role('Admin') + return if deny_if_not_role(Z_ROLENAME_ADMIN) model_create_render(Ticket::State, params) end # PUT /ticket_states/1 def update - return if deny_if_not_role('Admin') + return if deny_if_not_role(Z_ROLENAME_ADMIN) model_update_render(Ticket::State, params) end # DELETE /ticket_states/1 def destroy - return if deny_if_not_role('Admin') + return if deny_if_not_role(Z_ROLENAME_ADMIN) model_destory_render(Ticket::State, params) end end diff --git a/config/initializers/zammad_constants.rb b/config/initializers/zammad_constants.rb new file mode 100644 index 000000000..c216e772c --- /dev/null +++ b/config/initializers/zammad_constants.rb @@ -0,0 +1,7 @@ +# Copyright (C) 2014 Zammad Foundation, http://zammad-foundation.org/ + +# Prefix all zammad constants w/ Z_ + +# Prefix all rolenames with Z_ROLENAME +Z_ROLENAME_ADMIN = 'Admin' +