Small code style improvements.

This commit is contained in:
Martin Edenhofer 2012-10-05 08:42:27 +02:00
parent e9e156b074
commit aca7a62cef

View file

@ -62,7 +62,7 @@ class Channel::Twitter2
# find tweets # find tweets
all_tweets.each do |tweet| all_tweets.each do |tweet|
# check if tweet is already imported # check if tweet is already imported
article = Ticket::Article.where( :message_id => tweet.id.to_s ).first article = Ticket::Article.where( :message_id => tweet.id.to_s ).first
@ -72,16 +72,16 @@ class Channel::Twitter2
# use transaction # use transaction
ActiveRecord::Base.transaction do ActiveRecord::Base.transaction do
puts 'import tweet' puts 'import tweet'
fetch_import(tweet, channel, group) fetch_import( tweet, channel, group )
end end
# execute ticket events # execute ticket events
Ticket::Observer::Notification.transaction Ticket::Observer::Notification.transaction
end end
end end
def fetch_import(tweet, channel, group) def fetch_import(tweet, channel, group)
# do sender lockup if needed # do sender lockup if needed
sender = nil sender = nil
@ -160,10 +160,10 @@ class Channel::Twitter2
else else
puts 'user exists'#, user.inspect puts 'user exists'#, user.inspect
end end
# set current user # set current user
UserInfo.current_user_id = user.id UserInfo.current_user_id = user.id
return user return user
end end
@ -218,7 +218,7 @@ class Channel::Twitter2
return ticket return ticket
end end
def fetch_article_create(user,ticket,tweet, sender) def fetch_article_create(user,ticket,tweet, sender)
# find if record already exists # find if record already exists
@ -241,8 +241,8 @@ class Channel::Twitter2
article = Ticket::Article.create( article = Ticket::Article.create(
:created_by_id => user.id, :created_by_id => user.id,
:ticket_id => ticket.id, :ticket_id => ticket.id,
:ticket_article_type_id => Ticket::Article::Type.where(:name => @article_type).first.id, :ticket_article_type_id => Ticket::Article::Type.where( :name => @article_type ).first.id,
:ticket_article_sender_id => Ticket::Article::Sender.where(:name => 'Customer').first.id, :ticket_article_sender_id => Ticket::Article::Sender.where( :name => 'Customer' ).first.id,
:body => tweet.text, :body => tweet.text,
:from => sender.name, :from => sender.name,
:to => to, :to => to,