Sutty/trabajo-afectivo
5
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Knowledge Base Prep: Prevent potential conflict from HTML elements with identical IDs

Browse source
This commit is contained in:
Ryan Lue 2019-03-06 22:27:44 +08:00
parent 9ebf4697bb
commit bb20ca6d92
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/assets/javascripts/app/views/generic/table_row.jst.eco
View file

@ -39,10 +39,10 @@
<% else if header.name is 'action': %> <% else if header.name is 'action': %>
<% if @actions.length > 1: %> <% if @actions.length > 1: %>
<div class="dropdown dropdown--actions"> <div class="dropdown dropdown--actions">
<div class="btn btn--table btn--text btn--secondary js-action" id="tableActions" data-toggle="dropdown"> <div class="btn btn--table btn--text btn--secondary js-action" data-toggle="dropdown">
<%- @Icon('overflow-button') %> <%- @Icon('overflow-button') %>
</div> </div>
<ul class="dropdown-menu dropdown-menu-right js-table-action-menu" role="menu" aria-labelledby="tableActions"> <ul class="dropdown-menu dropdown-menu-right js-table-action-menu" role="menu">
<% for action in @actions: %> <% for action in @actions: %>
<li role="presentation" class="<%= action.class %>" data-table-action="<%= action.name %>"> <li role="presentation" class="<%= action.class %>" data-table-action="<%= action.name %>">
<a role="menuitem" tabindex="-1"> <a role="menuitem" tabindex="-1">
@ -76,4 +76,4 @@
<% end %> <% end %>
</td> </td>
<% end %> <% end %>
</tr> </tr>

2
test/browser/admin_channel_email_test.rb
View file

@ -162,7 +162,7 @@ class AdminChannelEmailTest < TestCase
) )
# now clone filter that we just created # now clone filter that we just created
click(css: '.content.active .table #tableActions') click(css: '.content.active .table .dropdown .btn--table')
click(css: '.content.active .table .dropdown .js-clone') click(css: '.content.active .table .dropdown .js-clone')
modal_ready() modal_ready()