From c099698c719c73cee6e0848ec925d0352fa59977 Mon Sep 17 00:00:00 2001
From: Rolf Schmidt <rolf.schmidt@zammad.com>
Date: Thu, 23 Sep 2021 12:38:44 +0100
Subject: [PATCH] Fixes #3758 - Saved conditions break on selections without
 reloading.

---
 app/models/core_workflow/attributes.rb |  1 +
 spec/models/core_workflow_spec.rb      | 45 ++++++++++++++++++++++++++
 2 files changed, 46 insertions(+)

diff --git a/app/models/core_workflow/attributes.rb b/app/models/core_workflow/attributes.rb
index 6463d7ab9..0cb4da236 100644
--- a/app/models/core_workflow/attributes.rb
+++ b/app/models/core_workflow/attributes.rb
@@ -55,6 +55,7 @@ class CoreWorkflow::Attributes
     # dont use lookup here because the cache will not
     # know about new attributes and make crashes
     @saved_only ||= payload_class.find_by(id: @payload['params']['id'])
+    @saved_only.dup
   end
 
   def saved
diff --git a/spec/models/core_workflow_spec.rb b/spec/models/core_workflow_spec.rb
index 08baa6699..92c94f933 100644
--- a/spec/models/core_workflow_spec.rb
+++ b/spec/models/core_workflow_spec.rb
@@ -1633,4 +1633,49 @@ RSpec.describe CoreWorkflow, type: :model do
       end
     end
   end
+
+  describe 'Saved conditions break on selections without reloading #3758', db_strategy: :reset do
+    let(:field_name) { SecureRandom.uuid }
+    let(:screens) do
+      {
+        edit: {
+          'ticket.agent' => {
+            shown: true,
+          },
+        },
+      }
+    end
+    let!(:workflow) do
+      create(:core_workflow,
+             object:          'Ticket',
+             condition_saved: {
+               "ticket.#{field_name}": {
+                 operator: 'is_not',
+                 value:    'true',
+               },
+             })
+    end
+    let(:payload) do
+      base_payload.merge('params' => { 'id' => ticket.id }, 'screen' => 'edit')
+    end
+
+    before do
+      create(:object_manager_attribute_boolean, object_name: 'Ticket', name: field_name, display: field_name, screens: screens)
+      ObjectManager::Attribute.migration_execute
+    end
+
+    it 'does match the workflow because saved value is false' do
+      expect(result[:matched_workflows]).to include(workflow.id)
+    end
+
+    context 'when params contain boolean field true' do
+      let(:payload) do
+        base_payload.merge('params' => { 'id' => ticket.id, field_name => true }, 'screen' => 'edit')
+      end
+
+      it 'does match the workflow because saved value is false' do
+        expect(result[:matched_workflows]).to include(workflow.id)
+      end
+    end
+  end
 end