From c1f2fb77fe87de901f5e6f835b1a1aff6dd41109 Mon Sep 17 00:00:00 2001
From: Umar Sheikh <umar.m.sheikh@gmail.com>
Date: Thu, 9 Nov 2017 15:53:34 +0500
Subject: [PATCH] tests for #1613, ensure that string is converted to boolean

---
 ...ject_manager_attributes_controller_test.rb | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 test/controllers/object_manager_attributes_controller_test.rb

diff --git a/test/controllers/object_manager_attributes_controller_test.rb b/test/controllers/object_manager_attributes_controller_test.rb
new file mode 100644
index 000000000..69073eeeb
--- /dev/null
+++ b/test/controllers/object_manager_attributes_controller_test.rb
@@ -0,0 +1,37 @@
+# encoding: utf-8
+require 'test_helper'
+
+class ObjectManagerAttributesControllerTest < ActionDispatch::IntegrationTest
+  setup do
+
+    # set accept header
+    @headers = { 'ACCEPT' => 'application/json', 'CONTENT_TYPE' => 'application/json' }
+
+    # create agent
+    roles  = Role.where(name: 'Admin')
+    groups = Group.all
+
+    UserInfo.current_user_id = 1
+    @admin = User.create_or_update(
+      login: 'tickets-admin',
+      firstname: 'Tickets',
+      lastname: 'Admin',
+      email: 'tickets-admin@example.com',
+      password: 'adminpw',
+      active: true,
+      roles: roles,
+      groups: groups,
+    )
+  end
+  test 'converts string to boolean for default option' do
+    credentials = ActionController::HttpAuthentication::Basic.encode_credentials('tickets-admin@example.com', 'adminpw')
+
+    post '/api/v1/object_manager_attributes', params: { 'name' => 'customdescription2', 'object' => 'Ticket', 'display' => 'custom description 2', 'active' => true, 'data_type' => 'boolean', 'data_option' => { 'options' => { 'true' => '', 'false' => '' }, 'default' => 'true' }, 'screens' => { 'create_middle' => { 'ticket.customer' => { 'shown' => true, 'item_class' => 'column' }, 'ticket.agent' => { 'shown' => true, 'item_class' => 'column' } }, 'edit' => { 'ticket.customer' => { 'shown' => true }, 'ticket.agent' => { 'shown' => true } } }, 'id' => 'c-192' }.to_json, headers: @headers.merge('Authorization' => credentials)
+    assert_response :success
+    result = JSON.parse @response.body
+    obj = ObjectManager::Attribute.find result['id']
+    assert_equal true, obj.data_option['default']
+    assert_equal 'boolean', obj.data_type
+    obj.destroy
+  end
+end