Sutty/trabajo-afectivo
5
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Add response body to result of client errors because there might be information provided by the server.

Browse source
This commit is contained in:
Thorsten Eckel 2018-06-22 14:27:32 +02:00
parent 21d8862988
commit c3105bb804
2 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
lib/user_agent.rb
View file

@ -401,6 +401,7 @@ returns
error: "Client Error: #{response.inspect}!", error: "Client Error: #{response.inspect}!",
success: false, success: false,
code: response.code, code: response.code,
body: response.body
) )
when Net::HTTPInternalServerError when Net::HTTPInternalServerError
return Result.new( return Result.new(

12
test/integration/user_agent_test.rb
View file

@ -157,7 +157,7 @@ class UserAgentTest < ActiveSupport::TestCase
assert(result) assert(result)
assert_equal(false, result.success?) assert_equal(false, result.success?)
assert_equal('401', result.code) assert_equal('401', result.code)
assert_equal(NilClass, result.body.class) assert_equal("HTTP Basic: Access denied.\n", result.body)
# post / 200 # post / 200
result = UserAgent.post( result = UserAgent.post(
@ -195,7 +195,7 @@ class UserAgentTest < ActiveSupport::TestCase
assert(result) assert(result)
assert_equal(false, result.success?) assert_equal(false, result.success?)
assert_equal('401', result.code) assert_equal('401', result.code)
assert_equal(NilClass, result.body.class) assert_equal("HTTP Basic: Access denied.\n", result.body)
# put / 200 # put / 200
result = UserAgent.put( result = UserAgent.put(
@ -233,7 +233,7 @@ class UserAgentTest < ActiveSupport::TestCase
assert(result) assert(result)
assert_equal(false, result.success?) assert_equal(false, result.success?)
assert_equal('401', result.code) assert_equal('401', result.code)
assert_equal(NilClass, result.body.class) assert_equal("HTTP Basic: Access denied.\n", result.body)
# delete / 200 # delete / 200
result = UserAgent.delete( result = UserAgent.delete(
@ -264,7 +264,7 @@ class UserAgentTest < ActiveSupport::TestCase
assert(result) assert(result)
assert_equal(false, result.success?) assert_equal(false, result.success?)
assert_equal('401', result.code) assert_equal('401', result.code)
assert_equal(NilClass, result.body.class) assert_equal("HTTP Basic: Access denied.\n", result.body)
end end
# check # check
@ -315,7 +315,7 @@ class UserAgentTest < ActiveSupport::TestCase
assert(result) assert(result)
assert_equal(false, result.success?) assert_equal(false, result.success?)
assert_equal('401', result.code) assert_equal('401', result.code)
assert_equal(NilClass, result.body.class) assert_equal("HTTP Basic: Access denied.\n", result.body)
end end
# check # check
@ -479,7 +479,7 @@ class UserAgentTest < ActiveSupport::TestCase
assert(result.body =~ /"remote_ip":"#{ENV['ZAMMAD_PROXY_REMOTE_IP_CHECK']}"/) assert(result.body =~ /"remote_ip":"#{ENV['ZAMMAD_PROXY_REMOTE_IP_CHECK']}"/)
end end
# get / 401 # get / 404
result = UserAgent.get( result = UserAgent.get(
"#{host}/test/not_existing", "#{host}/test/not_existing",
{ {