Sutty/trabajo-afectivo
5
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix Issue 2541 migration spec (prevent leaky test setup)

Browse source
This commit is contained in:
Ryan Lue 2019-04-10 17:03:39 +08:00 committed by Thorsten Eckel
parent 00934ef4f4
commit cdf4eaf92a
1 changed files with 43 additions and 47 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

70
spec/db/migrate/issue_2541_fix_notification_email_without_body_spec.rb
View file

@ -1,61 +1,57 @@
require 'rails_helper'
RSpec.describe Issue2541FixNotificationEmailWithoutBody, type: :db_migration do
describe '"body" attribute management' do
# We use #update_columns to bypass callbacks
# that would prevent the record from being saved with an empty body
before { subject.update_columns(perform: perform) }
context 'when migrating Triggers' do
before(:all) { Trigger.skip_callback(:create, :before, :validate_perform) }
it "updates empty perform['notification.email']['body'] attribute" do
trigger = create(:trigger,
perform: {
'notification.email' => {
let(:perform) do
{
type => {
'body' => '',
'recipient' => 'article_last_sender',
'subject' => 'Thanks for your inquiry (#{ticket.title})', # rubocop:disable Lint/InterpolationCheck
},
})
expect { migrate }.to change { trigger.reload.perform['notification.email']['body'] }.from('').to('-')
}
end
it "updates empty perform['notification.sms']['body'] attribute" do
trigger = create(:trigger,
perform: {
'notification.sms' => {
'body' => '',
'recipient' => 'article_last_sender',
},
})
context 'when migrating Triggers' do
subject(:trigger) { create(:trigger) }
context 'for email' do
let(:type) { 'notification.email' }
it "updates empty perform['notification.email']['body'] attribute" do
expect { migrate }.to change { trigger.reload.perform['notification.email']['body'] }.from('').to('-')
end
end
context 'for SMS' do
let(:type) { 'notification.sms' }
it "updates empty perform['notification.sms']['body'] attribute" do
expect { migrate }.to change { trigger.reload.perform['notification.sms']['body'] }.from('').to('-')
end
end
end
context 'when migrating Jobs' do
before(:all) { Job.skip_callback(:create, :before, :validate_perform) }
subject(:job) { create(:job) }
let(:type) { 'notification.email' }
it "updates empty perform['notification.email']['body'] attribute" do
job = create(:job,
perform: {
'notification.email' => {
'body' => '',
'recipient' => 'article_last_sender',
'subject' => 'Thanks for your inquiry (#{ticket.title})', # rubocop:disable Lint/InterpolationCheck
},
},)
expect { migrate }.to change { job.reload.perform['notification.email']['body'] }.from('').to('-')
end
end
it "re-enables 'Job.run' Scheduler" do
scheduler = Scheduler.find_by(method: 'Job.run')
scheduler.update!(active: false)
expect { migrate }.to change { scheduler.reload.active }.to(true)
end
describe 'scheduler management' do
let(:scheduler) { Scheduler.find_by(method: 'Job.run') }
before { scheduler.update!(active: false) }
it "re-enables 'Job.run' Scheduler" do
expect { migrate }.to change { scheduler.reload.active }.to(true)
end
end
end