From d0a0dc7d37394c0b2db7142dad45d58af4d87503 Mon Sep 17 00:00:00 2001
From: Martin Edenhofer <me@edenhofer.de>
Date: Tue, 12 Dec 2017 12:18:17 +0100
Subject: [PATCH] Show ticket edit form as disable if agent has read only
 permission.

---
 .gitlab-ci.yml                                           | 2 ++
 .../app/controllers/_application_controller_form.coffee  | 3 +++
 .../app/controllers/ticket_zoom/sidebar_ticket.coffee    | 5 +++--
 app/assets/javascripts/app/models/ticket.coffee          | 9 +++++++++
 app/models/ticket/screen_options.rb                      | 2 +-
 5 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 2e89ebccc..366486644 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -342,6 +342,7 @@ test:integration:zendesk_mysql:
     - rake db:migrate
     - ruby -I test/ test/integration/zendesk_import_test.rb
     - rake db:drop
+  allow_failure: true
 
 test:integration:zendesk_postgresql:
   stage: test
@@ -354,6 +355,7 @@ test:integration:zendesk_postgresql:
     - rake db:migrate
     - ruby -I test/ test/integration/zendesk_import_test.rb
     - rake db:drop
+  allow_failure: true
 
 test:integration:otrs_5_mysql:
   stage: test
diff --git a/app/assets/javascripts/app/controllers/_application_controller_form.coffee b/app/assets/javascripts/app/controllers/_application_controller_form.coffee
index bc82db034..91fdcbdb1 100644
--- a/app/assets/javascripts/app/controllers/_application_controller_form.coffee
+++ b/app/assets/javascripts/app/controllers/_application_controller_form.coffee
@@ -86,6 +86,9 @@ class App.ControllerForm extends App.Controller
     for attribute in @attributes
       attribute_count = attribute_count + 1
 
+      if @isDisabled == true
+        attribute.disabled = true
+
       # add item
       item = @formGenItem(attribute, className, fieldset, attribute_count)
       item.appendTo(fieldset)
diff --git a/app/assets/javascripts/app/controllers/ticket_zoom/sidebar_ticket.coffee b/app/assets/javascripts/app/controllers/ticket_zoom/sidebar_ticket.coffee
index cb656f976..c2c950076 100644
--- a/app/assets/javascripts/app/controllers/ticket_zoom/sidebar_ticket.coffee
+++ b/app/assets/javascripts/app/controllers/ticket_zoom/sidebar_ticket.coffee
@@ -20,8 +20,9 @@ class Edit extends App.ObserverController
       handlers:  [
         @ticketFormChanges
       ]
-      filter:    @formMeta.filter
-      params:    defaults
+      filter:     @formMeta.filter
+      params:     defaults
+      isDisabled: !ticket.editable()
       #bookmarkable: true
     )
 
diff --git a/app/assets/javascripts/app/models/ticket.coffee b/app/assets/javascripts/app/models/ticket.coffee
index a197bba69..463e400c9 100644
--- a/app/assets/javascripts/app/models/ticket.coffee
+++ b/app/assets/javascripts/app/models/ticket.coffee
@@ -244,3 +244,12 @@ class App.Ticket extends App.Model
           throw "Unknown operator: #{condition.operator}"
 
     result
+
+  editable: ->
+    group_ids = App.Session.get('group_ids')
+    if _.isEmpty(group_ids[@group_id])
+      return false
+    else if group_ids[@group_id] && !_.include(group_ids[@group_id], 'edit') && !_.include(group_ids[@group_id], 'full')
+      return false
+    true
+
diff --git a/app/models/ticket/screen_options.rb b/app/models/ticket/screen_options.rb
index c15b2ae81..f51aeaf31 100644
--- a/app/models/ticket/screen_options.rb
+++ b/app/models/ticket/screen_options.rb
@@ -90,7 +90,7 @@ returns
 
     filter[:group_id] = []
     groups = if params[:current_user].permissions?('ticket.agent')
-               params[:current_user].groups_access('create')
+               params[:current_user].groups_access(%w[create edit])
              else
                Group.where(active: true)
              end