Improved error handling.

lib/auth/developer.rb

@@ -1,16 +1,14 @@
 # Copyright (C) 2012-2013 Zammad Foundation, http://zammad-foundation.org/
 
 module Auth::Developer
-  def self.check( _username, password, _config, user )
+  def self.check(username, password, _config, user)
 
     # development systems
-    if Setting.get('developer_mode') == true
+    return false if !username
-      if password == 'test'
+    return false if !user
+    return false if Setting.get('developer_mode') != true
+    return false if password != 'test'
     Rails.logger.info "System in developer mode, authentication for user #{user.login} ok."
-        return user
+    user
-      end
-    end
-
-    false
   end
 end

lib/auth/internal.rb

@@ -1,10 +1,11 @@
 # Copyright (C) 2012-2013 Zammad Foundation, http://zammad-foundation.org/
 
 module Auth::Internal
-  def self.check( _username, password, _config, user )
+  def self.check(username, password, _config, user)
 
     # return if no user exists
-    return nil if !user
+    return false if !username
+    return false if !user
 
     # sha auth check
     if user.password =~ /^\{sha2\}/