Follow up - 8790e389be
- Fixes issue #865 - Freshdesk import - Resolved remaining TODOs.
This commit is contained in:
parent
8790e389be
commit
d85ce751dc
2 changed files with 0 additions and 23 deletions
|
@ -20,21 +20,12 @@ class Sequencer
|
||||||
}
|
}
|
||||||
end
|
end
|
||||||
rescue TypeError => e
|
rescue TypeError => e
|
||||||
# TODO
|
|
||||||
# TimeTracking is not available in the plans: Sprout, Blossom
|
# TimeTracking is not available in the plans: Sprout, Blossom
|
||||||
# In this case `resource`s value is `["code", "require_feature"]`
|
# In this case `resource`s value is `["code", "require_feature"]`
|
||||||
# We should somehow detect that/the plan (no API available) to avoid
|
|
||||||
# running into this error and therefore performing unnecessary requests
|
|
||||||
# See:
|
# See:
|
||||||
# - Ticket# 1077135
|
# - Ticket# 1077135
|
||||||
# - https://support.freshdesk.com/support/solutions/articles/37583-keeping-track-of-time-spent
|
# - https://support.freshdesk.com/support/solutions/articles/37583-keeping-track-of-time-spent
|
||||||
#
|
|
||||||
# Idea: Maybe it's possible to use the "X-Ratelimit-Total"-Value from the header, because with this it
|
|
||||||
# should be possible to detect the plan.
|
|
||||||
|
|
||||||
logger.debug { e }
|
logger.debug { e }
|
||||||
|
|
||||||
# state.provide(:action, :failed)
|
|
||||||
state.provide(:action, :skipped)
|
state.provide(:action, :skipped)
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|
|
@ -8,20 +8,6 @@ RSpec.describe 'Import Freshdesk', type: :system, set_up: false, authenticated_a
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
# TODO: check/clarify how the ENV-works in the CI-Envoirment?
|
|
||||||
|
|
||||||
# TODO: check https://git.znuny.com/zammad/zammad/-/merge_requests/1506/
|
|
||||||
# comment out bellow block to use VCR tape for running freshdesk import
|
|
||||||
# this allows to work around freshdesk rate limiting
|
|
||||||
# works great for debugging freshdesk locally
|
|
||||||
# around do |example|
|
|
||||||
# VCR.temporary_ignore_regexps += [/^(\S+\.|)freshdesk.com$/, /^\S+.zdusercontent.com$/]
|
|
||||||
|
|
||||||
# example.run
|
|
||||||
|
|
||||||
# VCR.temporary_ignore_regexps -= [/^(\S+\.|)freshdesk.com$/, /^\S+.zdusercontent.com$/]
|
|
||||||
# end
|
|
||||||
|
|
||||||
describe 'fields validation', :use_vcr do
|
describe 'fields validation', :use_vcr do
|
||||||
before do
|
before do
|
||||||
visit '#import'
|
visit '#import'
|
||||||
|
|
Loading…
Reference in a new issue