From dd722f94c92fac7425910994ca790cf250830114 Mon Sep 17 00:00:00 2001
From: Martin Edenhofer <me@edenhofer.de>
Date: Tue, 11 Sep 2018 08:44:51 +0200
Subject: [PATCH] Improved UX if ticket title is ''.

---
 .../javascripts/app/views/agent_ticket_view/detail.jst.eco      | 2 +-
 app/assets/javascripts/app/views/link/info.jst.eco              | 2 +-
 .../javascripts/app/views/popover/user_ticket_list.jst.eco      | 2 +-
 app/assets/javascripts/app/views/ticket_zoom/title.jst.eco      | 2 +-
 .../javascripts/app/views/time_accounting/by_ticket.jst.eco     | 2 +-
 .../javascripts/app/views/widget/ticket_stats_list.jst.eco      | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/app/assets/javascripts/app/views/agent_ticket_view/detail.jst.eco b/app/assets/javascripts/app/views/agent_ticket_view/detail.jst.eco
index 050a35b40..ba30a90de 100644
--- a/app/assets/javascripts/app/views/agent_ticket_view/detail.jst.eco
+++ b/app/assets/javascripts/app/views/agent_ticket_view/detail.jst.eco
@@ -12,7 +12,7 @@
     </td>
     <td>
       <%- ticket.customer.avatar("50", "", "userInfo-avatar") %>
-      <h2 style="margin-top: 0px;"><a href="<%- ticket.uiUrl() %>" data-type="edit"><%= ticket.title %></a></h2>
+      <h2 style="margin-top: 0px;"><a href="<%- ticket.uiUrl() %>" data-type="edit"><%= ticket.title || '-' %></a></h2>
       <div class="horizontal">
         <div class="vertical flex">
           <table style="width: 100%;">
diff --git a/app/assets/javascripts/app/views/link/info.jst.eco b/app/assets/javascripts/app/views/link/info.jst.eco
index 52b191925..7a757986e 100644
--- a/app/assets/javascripts/app/views/link/info.jst.eco
+++ b/app/assets/javascripts/app/views/link/info.jst.eco
@@ -9,7 +9,7 @@
         <%- @Icon('task-state', item.iconClass()) %>
       </div>
       <div class="task-text">
-        <a class="name ticket-popover" data-id="<%- item.id %>" href="#ticket/zoom/<%= item.id %>"><%= item.title %></a>
+        <a class="name ticket-popover" data-id="<%- item.id %>" href="#ticket/zoom/<%= item.id %>"><%= item.title || '-' %></a>
         <%- @humanTime(item.created_at) %>
       </div>
       <div class="list-item-delete js-delete" data-object="Ticket" data-object-id="<%= item.id %>" data-link-type="<%= type %>" data-type="remove">
diff --git a/app/assets/javascripts/app/views/popover/user_ticket_list.jst.eco b/app/assets/javascripts/app/views/popover/user_ticket_list.jst.eco
index 9216f53d1..65de820b5 100644
--- a/app/assets/javascripts/app/views/popover/user_ticket_list.jst.eco
+++ b/app/assets/javascripts/app/views/popover/user_ticket_list.jst.eco
@@ -5,7 +5,7 @@
       <%- @Icon('task-state', ticket.iconClass()) %>
     </div>
     <div class="task-text">
-      <a class="name" data-id="<%- ticket.id %>" href="<%- ticket.uiUrl() %>">#<%= ticket.number %> <%= ticket.title %></a>
+      <a class="name" data-id="<%- ticket.id %>" href="<%- ticket.uiUrl() %>">#<%= ticket.number %> <%= ticket.title || '-' %></a>
       <%- @humanTime(ticket.created_at, false, 'time') %>
     </div>
   </li>
diff --git a/app/assets/javascripts/app/views/ticket_zoom/title.jst.eco b/app/assets/javascripts/app/views/ticket_zoom/title.jst.eco
index c4d66f32c..7687f434f 100644
--- a/app/assets/javascripts/app/views/ticket_zoom/title.jst.eco
+++ b/app/assets/javascripts/app/views/ticket_zoom/title.jst.eco
@@ -1 +1 @@
-<div contenteditable="true" class="ticket-title-update js-objectTitle" data-placeholder="<%- @Ti('Enter Title...') %>"><%= @object.title %></div>
\ No newline at end of file
+<div contenteditable="true" class="ticket-title-update js-objectTitle" data-placeholder="<%- @Ti('Enter Title...') %>"><%= @object.title || '-' %></div>
\ No newline at end of file
diff --git a/app/assets/javascripts/app/views/time_accounting/by_ticket.jst.eco b/app/assets/javascripts/app/views/time_accounting/by_ticket.jst.eco
index 0f395dbf9..802dd1c93 100644
--- a/app/assets/javascripts/app/views/time_accounting/by_ticket.jst.eco
+++ b/app/assets/javascripts/app/views/time_accounting/by_ticket.jst.eco
@@ -20,7 +20,7 @@
   <% for row in @rows: %>
   <tr>
     <td><a href="#ticket/zoom/<%- row.ticket.id %>"><%= row.ticket.number %></a>
-    <td title="<%= row.ticket.title %>"><%= row.ticket.title %>
+    <td title="<%= row.ticket.title %>"><%= row.ticket.title || '-' %>
     <td><%= row.customer %>
     <td><%= row.organization %>
     <td><%= row.agent %>
diff --git a/app/assets/javascripts/app/views/widget/ticket_stats_list.jst.eco b/app/assets/javascripts/app/views/widget/ticket_stats_list.jst.eco
index 43845ece2..1cf1bae10 100644
--- a/app/assets/javascripts/app/views/widget/ticket_stats_list.jst.eco
+++ b/app/assets/javascripts/app/views/widget/ticket_stats_list.jst.eco
@@ -8,7 +8,7 @@
       <%- @Icon('task-state', ticket.iconClass()) %>
     </div>
     <div class="task-text">
-      <a class="name ticket-popover" data-id="<%- ticket_id %>" href="<%- ticket.uiUrl() %>"><%= ticket.title %></a>
+      <a class="name ticket-popover" data-id="<%- ticket_id %>" href="<%- ticket.uiUrl() %>"><%= ticket.title || '-' %></a>
        <%- @humanTime(ticket.created_at, false, 'time') %>
     </div>
   </li>