diff --git a/app/assets/javascripts/app/controllers/_application_controller.js.coffee b/app/assets/javascripts/app/controllers/_application_controller.js.coffee index e843b2348..e58073755 100644 --- a/app/assets/javascripts/app/controllers/_application_controller.js.coffee +++ b/app/assets/javascripts/app/controllers/_application_controller.js.coffee @@ -94,7 +94,7 @@ class App.Controller extends Spine.Controller if window.clipboardData # IE window.clipboardData.setData( 'Text', text ) else - window.prompt( "Copy to clipboard: Ctrl+C, Enter", text ) + window.prompt( 'Copy to clipboard: Ctrl+C, Enter', text ) # disable all delay's and interval's disconnectClient: -> @@ -144,6 +144,7 @@ class App.Controller extends Spine.Controller try element.css( 'position', 'static' ) catch e + console.log 'error', e position = [ 15, 30, 15, 0, -15, -30, -15, 0 ] position = position.concat( position.concat( position ) ) @@ -486,7 +487,7 @@ class App.Controller extends Spine.Controller item.title = '???' # convert backend name space to local name space - item.object = item.object.replace("::", '') + item.object = item.object.replace('::', '') # lookup real data if App[item.object] && App[item.object].exists( item.o_id ) @@ -659,7 +660,7 @@ class App.SessionMessage extends App.ControllerModal window.location.href = window.location.href return true - throw "Cant reload page!" + throw 'Cant reload page!' class App.UpdateHeader extends App.Controller constructor: -> diff --git a/app/assets/javascripts/app/controllers/_channel/form.js.coffee b/app/assets/javascripts/app/controllers/_channel/form.js.coffee index a3c0b03cf..5c539db61 100644 --- a/app/assets/javascripts/app/controllers/_channel/form.js.coffee +++ b/app/assets/javascripts/app/controllers/_channel/form.js.coffee @@ -1,3 +1,4 @@ +# coffeelint: disable=no_unnecessary_double_quotes class App.ChannelForm extends App.Controller events: 'change form.js-params': 'updateParams' diff --git a/app/assets/javascripts/app/controllers/_dashboard/first_steps_clues.js.coffee b/app/assets/javascripts/app/controllers/_dashboard/first_steps_clues.js.coffee index f88d415a8..9792e3277 100644 --- a/app/assets/javascripts/app/controllers/_dashboard/first_steps_clues.js.coffee +++ b/app/assets/javascripts/app/controllers/_dashboard/first_steps_clues.js.coffee @@ -318,7 +318,7 @@ class App.FirstStepsClues extends App.Controller perform: (actions, container) -> for action in actions - if action.indexOf(" ") < 0 + if action.indexOf(' ') < 0 # 'click' eventName = action target = container diff --git a/app/assets/javascripts/app/controllers/_profile/avatar.js.coffee b/app/assets/javascripts/app/controllers/_profile/avatar.js.coffee index 37cf87069..57c6635b1 100644 --- a/app/assets/javascripts/app/controllers/_profile/avatar.js.coffee +++ b/app/assets/javascripts/app/controllers/_profile/avatar.js.coffee @@ -365,7 +365,7 @@ class Camera extends App.ControllerModal # cache raw video data @cacheScreenshot() catch e - if e.name is "NS_ERROR_NOT_AVAILABLE" + if e.name is 'NS_ERROR_NOT_AVAILABLE' setTimeout @updatePreview, 200 else throw e diff --git a/app/assets/javascripts/app/controllers/_ui_element/autocompletion.js.coffee b/app/assets/javascripts/app/controllers/_ui_element/autocompletion.js.coffee index 78e66b6a0..142b3be2e 100644 --- a/app/assets/javascripts/app/controllers/_ui_element/autocompletion.js.coffee +++ b/app/assets/javascripts/app/controllers/_ui_element/autocompletion.js.coffee @@ -1,4 +1,4 @@ -# coffeelint: disable=camel_case_classes +# coffeelint: disable=camel_case_classes,no_interpolation_in_single_quotes class App.UiElement.autocompletion @render: (attribute, params) -> diff --git a/app/assets/javascripts/app/controllers/_ui_element/richtext.js.coffee b/app/assets/javascripts/app/controllers/_ui_element/richtext.js.coffee index be0d91716..db688d2be 100644 --- a/app/assets/javascripts/app/controllers/_ui_element/richtext.js.coffee +++ b/app/assets/javascripts/app/controllers/_ui_element/richtext.js.coffee @@ -88,7 +88,7 @@ class App.UiElement.richtext # Called during upload progress, first parameter # is decimal value from 0 to 100. onProgress: (progress, fileSize, uploadedBytes) => - @progressBar.width(parseInt(progress) + "%") + @progressBar.width(parseInt(progress) + '%') @progressText.text(parseInt(progress)) # hide cancel on 90% if parseInt(progress) >= 90 diff --git a/app/assets/javascripts/app/controllers/_ui_element/textarea.js.coffee b/app/assets/javascripts/app/controllers/_ui_element/textarea.js.coffee index 077d9d0c4..83b2b9aef 100644 --- a/app/assets/javascripts/app/controllers/_ui_element/textarea.js.coffee +++ b/app/assets/javascripts/app/controllers/_ui_element/textarea.js.coffee @@ -5,11 +5,11 @@ class App.UiElement.textarea item = $( App.view('generic/textarea')( attribute: attribute ) + '
' ) a = -> - visible = $( item[0] ).is(":visible") + visible = $( item[0] ).is(':visible') if visible && !$( item[0] ).expanding('active') $( item[0] ).expanding() $( item[0] ).on('focus', -> - visible = $( item[0] ).is(":visible") + visible = $( item[0] ).is(':visible') if visible && !$( item[0] ).expanding('active') $( item[0] ).expanding().focus() ) diff --git a/app/assets/javascripts/app/controllers/agent_ticket_create.js.coffee b/app/assets/javascripts/app/controllers/agent_ticket_create.js.coffee index ac5169023..26bec6e82 100644 --- a/app/assets/javascripts/app/controllers/agent_ticket_create.js.coffee +++ b/app/assets/javascripts/app/controllers/agent_ticket_create.js.coffee @@ -448,7 +448,7 @@ class App.TicketCreate extends App.Controller return # if not, show start screen - ui.navigate "#" + ui.navigate '#' fail: -> ui.log 'save failed!' diff --git a/app/assets/javascripts/app/controllers/getting_started.js.coffee b/app/assets/javascripts/app/controllers/getting_started.js.coffee index 41bb873aa..d3e6d2d96 100644 --- a/app/assets/javascripts/app/controllers/getting_started.js.coffee +++ b/app/assets/javascripts/app/controllers/getting_started.js.coffee @@ -314,7 +314,7 @@ class Base extends App.Wizard logoUrl: logoUrl organization: organization ) - @$("input, select").first().focus() + @$('input, select').first().focus() onLogoPick: (event) => reader = new FileReader() diff --git a/app/assets/javascripts/app/controllers/layout_ref.js.coffee b/app/assets/javascripts/app/controllers/layout_ref.js.coffee index 7093e6fa4..1184dcec4 100644 --- a/app/assets/javascripts/app/controllers/layout_ref.js.coffee +++ b/app/assets/javascripts/app/controllers/layout_ref.js.coffee @@ -180,9 +180,9 @@ class LayoutRefCommunicationReply extends App.ControllerContent if @content is 'no_content' @content = '' else if @content is 'content' - @content = "some content la la la la" + @content = 'some content la la la la' else - @content = "some
multiline content
12
3
" + @content = 'some
multiline content
12
3
' @render() @@ -255,7 +255,7 @@ class LayoutRefCommunicationReply extends App.ControllerContent @attachmentPlaceholder.velocity properties: - translateX: -@attachmentInputHolder.position().left + "px" + translateX: -@attachmentInputHolder.position().left + 'px' options: duration: duration easing: 'easeOutQuad' @@ -358,7 +358,7 @@ class LayoutRefCommunicationReply extends App.ControllerContent return ( size / Math.pow(1024, i) ).toFixed(2) * 1 + ' ' + ['B', 'kB', 'MB', 'GB', 'TB'][i] updateUploadProgress: (progress) => - @progressBar.width(progress + "%") + @progressBar.width(progress + '%') @progressText.text(progress) if progress is 100 @@ -553,7 +553,7 @@ class App.ControllerWizard extends App.ControllerContent button = $(e.currentTarget) switch button.attr('data-action') - when "reveal" then @showNextButton button + when 'reveal' then @showNextButton button showNextButton: (sibling) -> sibling.parents('.wizard-slide').find('.btn.hide').removeClass('hide') @@ -587,7 +587,7 @@ class ImportWizard extends App.ControllerWizard @otrsLink.on 'input', _.debounce(@checkOtrsLink, 600) checkOtrsLink: (e) => - if @otrsLink.val() is "" + if @otrsLink.val() is '' @inputFeedback.attr('data-state', '') return @@ -802,28 +802,28 @@ class TicketZoomRef extends App.ControllerContent colors: [ { name: 'Yellow' - color: "#f7e7b2" + color: '#f7e7b2' }, { name: 'Green' - color: "#bce7b6" + color: '#bce7b6' }, { name: 'Blue' - color: "#b3ddf9" + color: '#b3ddf9' }, { name: 'Pink' - color: "#fea9c5" + color: '#fea9c5' }, { name: 'Purple' - color: "#eac5ee" + color: '#eac5ee' } ] activeColorIndex: 0 - highlightClassPrefix: "highlight-" + highlightClassPrefix: 'highlight-' constructor: -> super @@ -1244,7 +1244,7 @@ class CluesRef extends App.ControllerContent perform: (actions, container) -> for action in actions - if action.indexOf(" ") < 0 + if action.indexOf(' ') < 0 # 'click' eventName = action target = container @@ -1398,7 +1398,7 @@ class SchedulersRef extends App.ControllerContent for hour in hours # split off am/pm - [hour, suffix] = hour.split(" ") + [hour, suffix] = hour.split(' ') for minute in minutes combined = "#{ hour }:#{ minute }" @@ -1434,7 +1434,7 @@ class InputsRef extends App.ControllerContent name: 'project-name' id: 'project-name-123' placeholder: 'Enter Project Name' - options: [{"value":0,"name":"Apple"},{"value":1,"name":"Microsoft","selected":true},{"value":2,"name":"Google"},{"value":3,"name":"Deutsche Bahn"},{"value":4,"name":"Sparkasse"},{"value":5,"name":"Deutsche Post"},{"value":6,"name":"Mitfahrzentrale"},{"value":7,"name":"Starbucks"},{"value":8,"name":"Mac Donalds"},{"value":9,"name":"Flixbus"},{"value":10,"name":"Betahaus"},{"value":11,"name":"Bruno Banani"},{"value":12,"name":"Alpina"},{"value":13,"name":"Samsung"},{"value":14,"name":"ChariTea"},{"value":15,"name":"fritz-kola"},{"value":16,"name":"Vitamin Water"},{"value":17,"name":"Znuny"},{"value":18,"name":"Max & Moritz"}] + options: [{value:0,name:'Apple'},{value:1,name:'Microsoft',selected:true},{value:2,name:'Google'},{value:3,name:'Deutsche Bahn'},{value:4,name:'Sparkasse'},{value:5,name:'Deutsche Post'},{value:6,name:'Mitfahrzentrale'},{value:7,name:'Starbucks'},{value:8,name:'Mac Donalds'},{value:9,name:'Flixbus'},{value:10,name:'Betahaus'},{value:11,name:'Bruno Banani'},{value:12,name:'Alpina'},{value:13,name:'Samsung'},{value:14,name:'ChariTea'},{value:15,name:'fritz-kola'},{value:16,name:'Vitamin Water'},{value:17,name:'Znuny'},{value:18,name:'Max & Moritz'}] @$('.searchableSelectPlaceholder').replaceWith( searchableSelectObject.element() ) # selectable search @@ -1493,7 +1493,7 @@ class CalendarSubscriptionsRef extends App.ControllerContent if data.length is 0 @output .attr 'disabled', true - .text "No subscriptions active" + .text 'No subscriptions active' return # check if all my tickets got selected @@ -1502,21 +1502,21 @@ class CalendarSubscriptionsRef extends App.ControllerContent if own.length > 0 if own.length is optionCount - modules.push "all my tickets" + modules.push 'all my tickets' else modules.push.apply modules, own.map (entry) -> [option, value] = entry.name.split('/') return "#{ translationTable[value] } #{ translationTable[option] }" - modules[modules.length-1] += " tickets" + modules[modules.length-1] += ' tickets' if not_assigned.length > 0 if not_assigned.length is optionCount - modules.push "all not assigned tickets" + modules.push 'all not assigned tickets' else modules.push.apply modules, not_assigned.map (entry) -> [option, value] = entry.name.split('/') return "#{ translationTable[value] } #{ translationTable[option] }" - modules[modules.length-1] += " tickets" + modules[modules.length-1] += ' tickets' @output .attr 'disabled', false diff --git a/app/assets/javascripts/app/controllers/login.js.coffee b/app/assets/javascripts/app/controllers/login.js.coffee index fd616b921..d55e6f917 100644 --- a/app/assets/javascripts/app/controllers/login.js.coffee +++ b/app/assets/javascripts/app/controllers/login.js.coffee @@ -99,7 +99,7 @@ class Index extends App.ControllerContent # reset @Config.set( 'requested_url', '' ) else - @log 'notice', "REDIRECT to -#/-" + @log 'notice', 'REDIRECT to -#/-' @navigate '#/' error: (xhr, statusText, error) => diff --git a/app/assets/javascripts/app/controllers/object_manager.js.coffee b/app/assets/javascripts/app/controllers/object_manager.js.coffee index 75e9d353d..e963aa622 100644 --- a/app/assets/javascripts/app/controllers/object_manager.js.coffee +++ b/app/assets/javascripts/app/controllers/object_manager.js.coffee @@ -1,3 +1,4 @@ +# coffeelint: disable=duplicate_key class Index extends App.ControllerTabs header: 'Object Manager' constructor: -> diff --git a/app/assets/javascripts/app/controllers/taskbar_widget.js.coffee b/app/assets/javascripts/app/controllers/taskbar_widget.js.coffee index 7321b597e..d9e92226e 100644 --- a/app/assets/javascripts/app/controllers/taskbar_widget.js.coffee +++ b/app/assets/javascripts/app/controllers/taskbar_widget.js.coffee @@ -67,7 +67,7 @@ class App.TaskbarWidget extends App.Controller for item in items key = $(item).data('key') if !key - throw "No such key attributes found for task item" + throw 'No such key attributes found for task item' order.push key App.TaskManager.reorder( order ) @@ -78,7 +78,7 @@ class App.TaskbarWidget extends App.Controller if !key key = $(e.target).parents('a').data('key') if !key - throw "No such key attributes found for task item" + throw 'No such key attributes found for task item' # check if input has changed worker = App.TaskManager.worker( key ) diff --git a/app/assets/javascripts/app/controllers/ticket_zoom.js.coffee b/app/assets/javascripts/app/controllers/ticket_zoom.js.coffee index b31315180..584f3a051 100644 --- a/app/assets/javascripts/app/controllers/ticket_zoom.js.coffee +++ b/app/assets/javascripts/app/controllers/ticket_zoom.js.coffee @@ -511,7 +511,7 @@ class App.TicketZoom extends App.Controller # validate article articleParams = @formParam( @$('.article-add') ) - console.log "submit article", articleParams + console.log 'submit article', articleParams if articleParams['body'] articleParams.from = @Session.get().displayName() articleParams.ticket_id = ticket.id diff --git a/app/assets/javascripts/app/controllers/ticket_zoom/article_new.js.coffee b/app/assets/javascripts/app/controllers/ticket_zoom/article_new.js.coffee index f48634d15..180ac3b58 100644 --- a/app/assets/javascripts/app/controllers/ticket_zoom/article_new.js.coffee +++ b/app/assets/javascripts/app/controllers/ticket_zoom/article_new.js.coffee @@ -202,7 +202,7 @@ class App.TicketZoomArticleNew extends App.Controller # Called during upload progress, first parameter # is decimal value from 0 to 100. onProgress: (progress, fileSize, uploadedBytes) => - @progressBar.width(parseInt(progress) + "%") + @progressBar.width(parseInt(progress) + '%') @progressText.text(parseInt(progress)) # hide cancel on 90% if parseInt(progress) >= 90 @@ -250,7 +250,7 @@ class App.TicketZoomArticleNew extends App.Controller @recipientListArrow.css('top', arrowCenter) @recipientList.css('top', top) - $.Velocity.hook(@recipientList, 'transformOriginX', "0") + $.Velocity.hook(@recipientList, 'transformOriginX', '0') $.Velocity.hook(@recipientList, 'transformOriginY', "#{ arrowCenter }px") @recipientList.velocity @@ -288,7 +288,7 @@ class App.TicketZoomArticleNew extends App.Controller add_recipient: (e) -> e.stopPropagation() e.preventDefault() - console.log "add recipient", e + console.log 'add recipient', e # store recipient toggleVisibility: -> @@ -297,14 +297,14 @@ class App.TicketZoomArticleNew extends App.Controller .removeClass 'is-public' .addClass 'is-internal' - @$('[name="internal"]').val 'true' + @$('[name=internal]').val 'true' else @articleNewEdit .addClass 'is-public' .removeClass 'is-internal' - @$('[name="internal"]').val '' + @$('[name=internal]').val '' showSelectableArticleType: => @el.find('.js-articleTypes').removeClass('is-hidden') @@ -328,7 +328,7 @@ class App.TicketZoomArticleNew extends App.Controller setArticleType: (type) -> typeIcon = @$('.js-selectedType') @type = type - @$('[name="type"]').val(type) + @$('[name=type]').val(type) @articleNewEdit.attr('data-type', type) typeIcon.find('use').attr 'xlink:href', "#icon-#{@type}" @@ -340,7 +340,7 @@ class App.TicketZoomArticleNew extends App.Controller @$("[name=#{name}]").closest('.form-group').removeClass('hide') # check if signature need to be added - body = @$('[data-name="body"]').html() || '' + body = @$('[data-name=body]').html() || '' signature = undefined if @ticket.group.signature_id signature = App.Signature.find( @ticket.group.signature_id ) @@ -352,11 +352,11 @@ class App.TicketZoomArticleNew extends App.Controller if !App.Utils.lastLineEmpty(body) body = body + '