From df61622e3ecac76b892ea27c41a6a01ba6581bd3 Mon Sep 17 00:00:00 2001 From: Martin Edenhofer Date: Thu, 24 Sep 2015 15:04:45 +0200 Subject: [PATCH] Next coffeelint level. --- .../_application_controller.js.coffee | 7 ++-- .../app/controllers/_channel/form.js.coffee | 1 + .../_dashboard/first_steps_clues.js.coffee | 2 +- .../app/controllers/_profile/avatar.js.coffee | 2 +- .../_ui_element/autocompletion.js.coffee | 2 +- .../_ui_element/richtext.js.coffee | 2 +- .../_ui_element/textarea.js.coffee | 4 +- .../controllers/agent_ticket_create.js.coffee | 2 +- .../app/controllers/getting_started.js.coffee | 2 +- .../app/controllers/layout_ref.js.coffee | 40 +++++++++---------- .../app/controllers/login.js.coffee | 2 +- .../app/controllers/object_manager.js.coffee | 1 + .../app/controllers/taskbar_widget.js.coffee | 4 +- .../app/controllers/ticket_zoom.js.coffee | 2 +- .../ticket_zoom/article_new.js.coffee | 22 +++++----- .../ticket_zoom/article_view.js.coffee | 4 +- .../controllers/widget/hello_banner.js.coffee | 4 +- .../widget/online_notification.js.coffee | 2 +- .../controllers/widget/ticket_stats.js.coffee | 4 +- .../app/lib/app_init/log.js.coffee | 2 +- .../app/lib/app_init/track.js.coffee | 2 +- .../app/lib/app_post/pretty_date.js.coffee | 6 +-- .../app/lib/app_post/utils.js.coffee | 1 + .../app/lib/app_post/websocket.js.coffee | 8 ++-- .../javascripts/app/lib/spine/ajax.coffee | 2 +- .../javascripts/app/lib/spine/local.coffee | 1 + .../javascripts/app/lib/spine/route.coffee | 2 +- .../javascripts/app/lib/spine/spine.coffee | 2 +- .../app/models/organization.js.coffee | 4 +- .../javascripts/app/models/ticket.js.coffee | 2 +- .../javascripts/app/models/user.js.coffee | 6 +-- coffeelint.json | 24 +++++------ 32 files changed, 88 insertions(+), 83 deletions(-) diff --git a/app/assets/javascripts/app/controllers/_application_controller.js.coffee b/app/assets/javascripts/app/controllers/_application_controller.js.coffee index e843b2348..e58073755 100644 --- a/app/assets/javascripts/app/controllers/_application_controller.js.coffee +++ b/app/assets/javascripts/app/controllers/_application_controller.js.coffee @@ -94,7 +94,7 @@ class App.Controller extends Spine.Controller if window.clipboardData # IE window.clipboardData.setData( 'Text', text ) else - window.prompt( "Copy to clipboard: Ctrl+C, Enter", text ) + window.prompt( 'Copy to clipboard: Ctrl+C, Enter', text ) # disable all delay's and interval's disconnectClient: -> @@ -144,6 +144,7 @@ class App.Controller extends Spine.Controller try element.css( 'position', 'static' ) catch e + console.log 'error', e position = [ 15, 30, 15, 0, -15, -30, -15, 0 ] position = position.concat( position.concat( position ) ) @@ -486,7 +487,7 @@ class App.Controller extends Spine.Controller item.title = '???' # convert backend name space to local name space - item.object = item.object.replace("::", '') + item.object = item.object.replace('::', '') # lookup real data if App[item.object] && App[item.object].exists( item.o_id ) @@ -659,7 +660,7 @@ class App.SessionMessage extends App.ControllerModal window.location.href = window.location.href return true - throw "Cant reload page!" + throw 'Cant reload page!' class App.UpdateHeader extends App.Controller constructor: -> diff --git a/app/assets/javascripts/app/controllers/_channel/form.js.coffee b/app/assets/javascripts/app/controllers/_channel/form.js.coffee index a3c0b03cf..5c539db61 100644 --- a/app/assets/javascripts/app/controllers/_channel/form.js.coffee +++ b/app/assets/javascripts/app/controllers/_channel/form.js.coffee @@ -1,3 +1,4 @@ +# coffeelint: disable=no_unnecessary_double_quotes class App.ChannelForm extends App.Controller events: 'change form.js-params': 'updateParams' diff --git a/app/assets/javascripts/app/controllers/_dashboard/first_steps_clues.js.coffee b/app/assets/javascripts/app/controllers/_dashboard/first_steps_clues.js.coffee index f88d415a8..9792e3277 100644 --- a/app/assets/javascripts/app/controllers/_dashboard/first_steps_clues.js.coffee +++ b/app/assets/javascripts/app/controllers/_dashboard/first_steps_clues.js.coffee @@ -318,7 +318,7 @@ class App.FirstStepsClues extends App.Controller perform: (actions, container) -> for action in actions - if action.indexOf(" ") < 0 + if action.indexOf(' ') < 0 # 'click' eventName = action target = container diff --git a/app/assets/javascripts/app/controllers/_profile/avatar.js.coffee b/app/assets/javascripts/app/controllers/_profile/avatar.js.coffee index 37cf87069..57c6635b1 100644 --- a/app/assets/javascripts/app/controllers/_profile/avatar.js.coffee +++ b/app/assets/javascripts/app/controllers/_profile/avatar.js.coffee @@ -365,7 +365,7 @@ class Camera extends App.ControllerModal # cache raw video data @cacheScreenshot() catch e - if e.name is "NS_ERROR_NOT_AVAILABLE" + if e.name is 'NS_ERROR_NOT_AVAILABLE' setTimeout @updatePreview, 200 else throw e diff --git a/app/assets/javascripts/app/controllers/_ui_element/autocompletion.js.coffee b/app/assets/javascripts/app/controllers/_ui_element/autocompletion.js.coffee index 78e66b6a0..142b3be2e 100644 --- a/app/assets/javascripts/app/controllers/_ui_element/autocompletion.js.coffee +++ b/app/assets/javascripts/app/controllers/_ui_element/autocompletion.js.coffee @@ -1,4 +1,4 @@ -# coffeelint: disable=camel_case_classes +# coffeelint: disable=camel_case_classes,no_interpolation_in_single_quotes class App.UiElement.autocompletion @render: (attribute, params) -> diff --git a/app/assets/javascripts/app/controllers/_ui_element/richtext.js.coffee b/app/assets/javascripts/app/controllers/_ui_element/richtext.js.coffee index be0d91716..db688d2be 100644 --- a/app/assets/javascripts/app/controllers/_ui_element/richtext.js.coffee +++ b/app/assets/javascripts/app/controllers/_ui_element/richtext.js.coffee @@ -88,7 +88,7 @@ class App.UiElement.richtext # Called during upload progress, first parameter # is decimal value from 0 to 100. onProgress: (progress, fileSize, uploadedBytes) => - @progressBar.width(parseInt(progress) + "%") + @progressBar.width(parseInt(progress) + '%') @progressText.text(parseInt(progress)) # hide cancel on 90% if parseInt(progress) >= 90 diff --git a/app/assets/javascripts/app/controllers/_ui_element/textarea.js.coffee b/app/assets/javascripts/app/controllers/_ui_element/textarea.js.coffee index 077d9d0c4..83b2b9aef 100644 --- a/app/assets/javascripts/app/controllers/_ui_element/textarea.js.coffee +++ b/app/assets/javascripts/app/controllers/_ui_element/textarea.js.coffee @@ -5,11 +5,11 @@ class App.UiElement.textarea item = $( App.view('generic/textarea')( attribute: attribute ) + '
' ) a = -> - visible = $( item[0] ).is(":visible") + visible = $( item[0] ).is(':visible') if visible && !$( item[0] ).expanding('active') $( item[0] ).expanding() $( item[0] ).on('focus', -> - visible = $( item[0] ).is(":visible") + visible = $( item[0] ).is(':visible') if visible && !$( item[0] ).expanding('active') $( item[0] ).expanding().focus() ) diff --git a/app/assets/javascripts/app/controllers/agent_ticket_create.js.coffee b/app/assets/javascripts/app/controllers/agent_ticket_create.js.coffee index ac5169023..26bec6e82 100644 --- a/app/assets/javascripts/app/controllers/agent_ticket_create.js.coffee +++ b/app/assets/javascripts/app/controllers/agent_ticket_create.js.coffee @@ -448,7 +448,7 @@ class App.TicketCreate extends App.Controller return # if not, show start screen - ui.navigate "#" + ui.navigate '#' fail: -> ui.log 'save failed!' diff --git a/app/assets/javascripts/app/controllers/getting_started.js.coffee b/app/assets/javascripts/app/controllers/getting_started.js.coffee index 41bb873aa..d3e6d2d96 100644 --- a/app/assets/javascripts/app/controllers/getting_started.js.coffee +++ b/app/assets/javascripts/app/controllers/getting_started.js.coffee @@ -314,7 +314,7 @@ class Base extends App.Wizard logoUrl: logoUrl organization: organization ) - @$("input, select").first().focus() + @$('input, select').first().focus() onLogoPick: (event) => reader = new FileReader() diff --git a/app/assets/javascripts/app/controllers/layout_ref.js.coffee b/app/assets/javascripts/app/controllers/layout_ref.js.coffee index 7093e6fa4..1184dcec4 100644 --- a/app/assets/javascripts/app/controllers/layout_ref.js.coffee +++ b/app/assets/javascripts/app/controllers/layout_ref.js.coffee @@ -180,9 +180,9 @@ class LayoutRefCommunicationReply extends App.ControllerContent if @content is 'no_content' @content = '' else if @content is 'content' - @content = "some content la la la la" + @content = 'some content la la la la' else - @content = "

some

multiline content

1

2

3

" + @content = '

some

multiline content

1

2

3

' @render() @@ -255,7 +255,7 @@ class LayoutRefCommunicationReply extends App.ControllerContent @attachmentPlaceholder.velocity properties: - translateX: -@attachmentInputHolder.position().left + "px" + translateX: -@attachmentInputHolder.position().left + 'px' options: duration: duration easing: 'easeOutQuad' @@ -358,7 +358,7 @@ class LayoutRefCommunicationReply extends App.ControllerContent return ( size / Math.pow(1024, i) ).toFixed(2) * 1 + ' ' + ['B', 'kB', 'MB', 'GB', 'TB'][i] updateUploadProgress: (progress) => - @progressBar.width(progress + "%") + @progressBar.width(progress + '%') @progressText.text(progress) if progress is 100 @@ -553,7 +553,7 @@ class App.ControllerWizard extends App.ControllerContent button = $(e.currentTarget) switch button.attr('data-action') - when "reveal" then @showNextButton button + when 'reveal' then @showNextButton button showNextButton: (sibling) -> sibling.parents('.wizard-slide').find('.btn.hide').removeClass('hide') @@ -587,7 +587,7 @@ class ImportWizard extends App.ControllerWizard @otrsLink.on 'input', _.debounce(@checkOtrsLink, 600) checkOtrsLink: (e) => - if @otrsLink.val() is "" + if @otrsLink.val() is '' @inputFeedback.attr('data-state', '') return @@ -802,28 +802,28 @@ class TicketZoomRef extends App.ControllerContent colors: [ { name: 'Yellow' - color: "#f7e7b2" + color: '#f7e7b2' }, { name: 'Green' - color: "#bce7b6" + color: '#bce7b6' }, { name: 'Blue' - color: "#b3ddf9" + color: '#b3ddf9' }, { name: 'Pink' - color: "#fea9c5" + color: '#fea9c5' }, { name: 'Purple' - color: "#eac5ee" + color: '#eac5ee' } ] activeColorIndex: 0 - highlightClassPrefix: "highlight-" + highlightClassPrefix: 'highlight-' constructor: -> super @@ -1244,7 +1244,7 @@ class CluesRef extends App.ControllerContent perform: (actions, container) -> for action in actions - if action.indexOf(" ") < 0 + if action.indexOf(' ') < 0 # 'click' eventName = action target = container @@ -1398,7 +1398,7 @@ class SchedulersRef extends App.ControllerContent for hour in hours # split off am/pm - [hour, suffix] = hour.split(" ") + [hour, suffix] = hour.split(' ') for minute in minutes combined = "#{ hour }:#{ minute }" @@ -1434,7 +1434,7 @@ class InputsRef extends App.ControllerContent name: 'project-name' id: 'project-name-123' placeholder: 'Enter Project Name' - options: [{"value":0,"name":"Apple"},{"value":1,"name":"Microsoft","selected":true},{"value":2,"name":"Google"},{"value":3,"name":"Deutsche Bahn"},{"value":4,"name":"Sparkasse"},{"value":5,"name":"Deutsche Post"},{"value":6,"name":"Mitfahrzentrale"},{"value":7,"name":"Starbucks"},{"value":8,"name":"Mac Donalds"},{"value":9,"name":"Flixbus"},{"value":10,"name":"Betahaus"},{"value":11,"name":"Bruno Banani"},{"value":12,"name":"Alpina"},{"value":13,"name":"Samsung"},{"value":14,"name":"ChariTea"},{"value":15,"name":"fritz-kola"},{"value":16,"name":"Vitamin Water"},{"value":17,"name":"Znuny"},{"value":18,"name":"Max & Moritz"}] + options: [{value:0,name:'Apple'},{value:1,name:'Microsoft',selected:true},{value:2,name:'Google'},{value:3,name:'Deutsche Bahn'},{value:4,name:'Sparkasse'},{value:5,name:'Deutsche Post'},{value:6,name:'Mitfahrzentrale'},{value:7,name:'Starbucks'},{value:8,name:'Mac Donalds'},{value:9,name:'Flixbus'},{value:10,name:'Betahaus'},{value:11,name:'Bruno Banani'},{value:12,name:'Alpina'},{value:13,name:'Samsung'},{value:14,name:'ChariTea'},{value:15,name:'fritz-kola'},{value:16,name:'Vitamin Water'},{value:17,name:'Znuny'},{value:18,name:'Max & Moritz'}] @$('.searchableSelectPlaceholder').replaceWith( searchableSelectObject.element() ) # selectable search @@ -1493,7 +1493,7 @@ class CalendarSubscriptionsRef extends App.ControllerContent if data.length is 0 @output .attr 'disabled', true - .text "No subscriptions active" + .text 'No subscriptions active' return # check if all my tickets got selected @@ -1502,21 +1502,21 @@ class CalendarSubscriptionsRef extends App.ControllerContent if own.length > 0 if own.length is optionCount - modules.push "all my tickets" + modules.push 'all my tickets' else modules.push.apply modules, own.map (entry) -> [option, value] = entry.name.split('/') return "#{ translationTable[value] } #{ translationTable[option] }" - modules[modules.length-1] += " tickets" + modules[modules.length-1] += ' tickets' if not_assigned.length > 0 if not_assigned.length is optionCount - modules.push "all not assigned tickets" + modules.push 'all not assigned tickets' else modules.push.apply modules, not_assigned.map (entry) -> [option, value] = entry.name.split('/') return "#{ translationTable[value] } #{ translationTable[option] }" - modules[modules.length-1] += " tickets" + modules[modules.length-1] += ' tickets' @output .attr 'disabled', false diff --git a/app/assets/javascripts/app/controllers/login.js.coffee b/app/assets/javascripts/app/controllers/login.js.coffee index fd616b921..d55e6f917 100644 --- a/app/assets/javascripts/app/controllers/login.js.coffee +++ b/app/assets/javascripts/app/controllers/login.js.coffee @@ -99,7 +99,7 @@ class Index extends App.ControllerContent # reset @Config.set( 'requested_url', '' ) else - @log 'notice', "REDIRECT to -#/-" + @log 'notice', 'REDIRECT to -#/-' @navigate '#/' error: (xhr, statusText, error) => diff --git a/app/assets/javascripts/app/controllers/object_manager.js.coffee b/app/assets/javascripts/app/controllers/object_manager.js.coffee index 75e9d353d..e963aa622 100644 --- a/app/assets/javascripts/app/controllers/object_manager.js.coffee +++ b/app/assets/javascripts/app/controllers/object_manager.js.coffee @@ -1,3 +1,4 @@ +# coffeelint: disable=duplicate_key class Index extends App.ControllerTabs header: 'Object Manager' constructor: -> diff --git a/app/assets/javascripts/app/controllers/taskbar_widget.js.coffee b/app/assets/javascripts/app/controllers/taskbar_widget.js.coffee index 7321b597e..d9e92226e 100644 --- a/app/assets/javascripts/app/controllers/taskbar_widget.js.coffee +++ b/app/assets/javascripts/app/controllers/taskbar_widget.js.coffee @@ -67,7 +67,7 @@ class App.TaskbarWidget extends App.Controller for item in items key = $(item).data('key') if !key - throw "No such key attributes found for task item" + throw 'No such key attributes found for task item' order.push key App.TaskManager.reorder( order ) @@ -78,7 +78,7 @@ class App.TaskbarWidget extends App.Controller if !key key = $(e.target).parents('a').data('key') if !key - throw "No such key attributes found for task item" + throw 'No such key attributes found for task item' # check if input has changed worker = App.TaskManager.worker( key ) diff --git a/app/assets/javascripts/app/controllers/ticket_zoom.js.coffee b/app/assets/javascripts/app/controllers/ticket_zoom.js.coffee index b31315180..584f3a051 100644 --- a/app/assets/javascripts/app/controllers/ticket_zoom.js.coffee +++ b/app/assets/javascripts/app/controllers/ticket_zoom.js.coffee @@ -511,7 +511,7 @@ class App.TicketZoom extends App.Controller # validate article articleParams = @formParam( @$('.article-add') ) - console.log "submit article", articleParams + console.log 'submit article', articleParams if articleParams['body'] articleParams.from = @Session.get().displayName() articleParams.ticket_id = ticket.id diff --git a/app/assets/javascripts/app/controllers/ticket_zoom/article_new.js.coffee b/app/assets/javascripts/app/controllers/ticket_zoom/article_new.js.coffee index f48634d15..180ac3b58 100644 --- a/app/assets/javascripts/app/controllers/ticket_zoom/article_new.js.coffee +++ b/app/assets/javascripts/app/controllers/ticket_zoom/article_new.js.coffee @@ -202,7 +202,7 @@ class App.TicketZoomArticleNew extends App.Controller # Called during upload progress, first parameter # is decimal value from 0 to 100. onProgress: (progress, fileSize, uploadedBytes) => - @progressBar.width(parseInt(progress) + "%") + @progressBar.width(parseInt(progress) + '%') @progressText.text(parseInt(progress)) # hide cancel on 90% if parseInt(progress) >= 90 @@ -250,7 +250,7 @@ class App.TicketZoomArticleNew extends App.Controller @recipientListArrow.css('top', arrowCenter) @recipientList.css('top', top) - $.Velocity.hook(@recipientList, 'transformOriginX', "0") + $.Velocity.hook(@recipientList, 'transformOriginX', '0') $.Velocity.hook(@recipientList, 'transformOriginY', "#{ arrowCenter }px") @recipientList.velocity @@ -288,7 +288,7 @@ class App.TicketZoomArticleNew extends App.Controller add_recipient: (e) -> e.stopPropagation() e.preventDefault() - console.log "add recipient", e + console.log 'add recipient', e # store recipient toggleVisibility: -> @@ -297,14 +297,14 @@ class App.TicketZoomArticleNew extends App.Controller .removeClass 'is-public' .addClass 'is-internal' - @$('[name="internal"]').val 'true' + @$('[name=internal]').val 'true' else @articleNewEdit .addClass 'is-public' .removeClass 'is-internal' - @$('[name="internal"]').val '' + @$('[name=internal]').val '' showSelectableArticleType: => @el.find('.js-articleTypes').removeClass('is-hidden') @@ -328,7 +328,7 @@ class App.TicketZoomArticleNew extends App.Controller setArticleType: (type) -> typeIcon = @$('.js-selectedType') @type = type - @$('[name="type"]').val(type) + @$('[name=type]').val(type) @articleNewEdit.attr('data-type', type) typeIcon.find('use').attr 'xlink:href', "#icon-#{@type}" @@ -340,7 +340,7 @@ class App.TicketZoomArticleNew extends App.Controller @$("[name=#{name}]").closest('.form-group').removeClass('hide') # check if signature need to be added - body = @$('[data-name="body"]').html() || '' + body = @$('[data-name=body]').html() || '' signature = undefined if @ticket.group.signature_id signature = App.Signature.find( @ticket.group.signature_id ) @@ -352,11 +352,11 @@ class App.TicketZoomArticleNew extends App.Controller if !App.Utils.lastLineEmpty(body) body = body + '
' body = body + "
#{signatureFinished}
" - @$('[data-name="body"]').html(body) + @$('[data-name=body]').html(body) # remove old signature else - @$('[data-name="body"]').find("[data-signature=true]").remove() + @$('[data-name=body]').find('[data-signature=true]').remove() detectEmptyTextarea: => if !@textarea.text().trim() @@ -389,7 +389,7 @@ class App.TicketZoomArticleNew extends App.Controller easing: 'easeOutQuad' # scroll to bottom - @textarea.velocity "scroll", + @textarea.velocity 'scroll', container: @textarea.scrollParent() offset: 99999 duration: 300 @@ -411,7 +411,7 @@ class App.TicketZoomArticleNew extends App.Controller # move attachment text to the left bottom (bottom happens automatically) @attachmentPlaceholder.velocity properties: - translateX: -@attachmentInputHolder.position().left + "px" + translateX: -@attachmentInputHolder.position().left + 'px' options: duration: duration easing: 'easeOutQuad' diff --git a/app/assets/javascripts/app/controllers/ticket_zoom/article_view.js.coffee b/app/assets/javascripts/app/controllers/ticket_zoom/article_view.js.coffee index 601bd549c..bfe06603d 100644 --- a/app/assets/javascripts/app/controllers/ticket_zoom/article_view.js.coffee +++ b/app/assets/javascripts/app/controllers/ticket_zoom/article_view.js.coffee @@ -192,7 +192,7 @@ class ArticleViewItem extends App.Controller article.removeClass('state--folde-out') # scroll back up - article.velocity "scroll", + article.velocity 'scroll', container: article.scrollParent() offset: -article.offset().top - metaTop.outerHeight() duration: animSpeed @@ -224,7 +224,7 @@ class ArticleViewItem extends App.Controller metaTop.removeClass('hide') # balance out the top meta height by scrolling down - article.velocity("scroll", + article.velocity('scroll', container: article.scrollParent() offset: -article.offset().top + metaTop.outerHeight() duration: animSpeed diff --git a/app/assets/javascripts/app/controllers/widget/hello_banner.js.coffee b/app/assets/javascripts/app/controllers/widget/hello_banner.js.coffee index 0d537b506..882b69936 100644 --- a/app/assets/javascripts/app/controllers/widget/hello_banner.js.coffee +++ b/app/assets/javascripts/app/controllers/widget/hello_banner.js.coffee @@ -15,6 +15,6 @@ class Widget | Your Zammad Team! | """ - console.log(banner, "text-decoration: underline;", "text-decoration: none;") + console.log(banner, 'text-decoration: underline;', 'text-decoration: none;') -App.Config.set( 'hello_banner', Widget, 'Widgets' ) +App.Config.set('hello_banner', Widget, 'Widgets') diff --git a/app/assets/javascripts/app/controllers/widget/online_notification.js.coffee b/app/assets/javascripts/app/controllers/widget/online_notification.js.coffee index 22b5668f8..2c4373aa8 100644 --- a/app/assets/javascripts/app/controllers/widget/online_notification.js.coffee +++ b/app/assets/javascripts/app/controllers/widget/online_notification.js.coffee @@ -164,7 +164,7 @@ class App.OnlineNotificationWidget extends App.Controller container: 'body' html: true placement: 'right' - viewport: { "selector": "#app", "padding": 10 } + viewport: { selector: '#app', padding: 10 } template: App.view('widget/online_notification')() title: ' ' content: ' ' diff --git a/app/assets/javascripts/app/controllers/widget/ticket_stats.js.coffee b/app/assets/javascripts/app/controllers/widget/ticket_stats.js.coffee index c838c47cf..edb36c1c3 100644 --- a/app/assets/javascripts/app/controllers/widget/ticket_stats.js.coffee +++ b/app/assets/javascripts/app/controllers/widget/ticket_stats.js.coffee @@ -26,11 +26,11 @@ class App.TicketStats extends App.Controller load: (object) => if @organization - ajaxKey = "org_" + @organization.id + ajaxKey = "org_#{@organization.id}" data = organization_id: @organization.id else - ajaxKey = "user_" + @user.id + ajaxKey = "user_#{@user.id}" data = user_id: @user.id organization_id: @user.organization_id diff --git a/app/assets/javascripts/app/lib/app_init/log.js.coffee b/app/assets/javascripts/app/lib/app_init/log.js.coffee index 9983d6e4a..b204a7b7d 100644 --- a/app/assets/javascripts/app/lib/app_init/log.js.coffee +++ b/app/assets/javascripts/app/lib/app_init/log.js.coffee @@ -95,7 +95,7 @@ class _Singleton if !@moduleColorsMap[module] @moduleColorsMap[module]= @yieldColor() color = @moduleColorsMap[module] - colorString = "color: hsl(" + (color) + ",99%,40%); font-weight: bold" + colorString = 'color: hsl(' + (color) + ',99%,40%); font-weight: bold' logArgs = [prefix, colorString].concat(args) else logArgs = [prefix].concat(args) diff --git a/app/assets/javascripts/app/lib/app_init/track.js.coffee b/app/assets/javascripts/app/lib/app_init/track.js.coffee index 955cbcad2..e2bc8c3eb 100644 --- a/app/assets/javascripts/app/lib/app_init/track.js.coffee +++ b/app/assets/javascripts/app/lib/app_init/track.js.coffee @@ -130,7 +130,7 @@ class _trackSingleton newDataNew.push item catch e - # nothing + console.log 'error', e App.Ajax.request( type: 'POST' diff --git a/app/assets/javascripts/app/lib/app_post/pretty_date.js.coffee b/app/assets/javascripts/app/lib/app_post/pretty_date.js.coffee index 988abe815..a9b33eba7 100644 --- a/app/assets/javascripts/app/lib/app_post/pretty_date.js.coffee +++ b/app/assets/javascripts/app/lib/app_post/pretty_date.js.coffee @@ -12,11 +12,11 @@ class App.PrettyDate if diff > 0 escalated = '-' if diff >= 0 - style = "class=\"label label-danger\"" + style = 'class="label label-danger"' else if diff > -60 * 60 - style = "class=\"label label-warning\"" + style = 'class="label label-warning"' else - style = "class=\"label label-success\"" + style = 'class="label label-success"' # remember past/future direction = 'future' diff --git a/app/assets/javascripts/app/lib/app_post/utils.js.coffee b/app/assets/javascripts/app/lib/app_post/utils.js.coffee index c4e1f9196..724571ede 100644 --- a/app/assets/javascripts/app/lib/app_post/utils.js.coffee +++ b/app/assets/javascripts/app/lib/app_post/utils.js.coffee @@ -1,3 +1,4 @@ +# coffeelint: disable=no_unnecessary_double_quotes class App.Utils # textCleand = App.Utils.textCleanup( rawText ) diff --git a/app/assets/javascripts/app/lib/app_post/websocket.js.coffee b/app/assets/javascripts/app/lib/app_post/websocket.js.coffee index 7cca34ed6..3ae91f2a8 100644 --- a/app/assets/javascripts/app/lib/app_post/websocket.js.coffee +++ b/app/assets/javascripts/app/lib/app_post/websocket.js.coffee @@ -272,7 +272,7 @@ class _webSocketSingleton extends App.Controller App.Delay.set @connect, 4500, 'websocket-try-reconnect-after-x-sec', 'ws' @ws.onerror = (e) => - @log 'debug', "ws:onerror", e + @log 'debug', 'ws:onerror', e _receiveMessage: (data = []) => @@ -289,17 +289,17 @@ class _webSocketSingleton extends App.Controller # fill collection if item['collection'] - @log 'debug', "onmessage collection:" + item['collection'] + @log 'debug', 'onmessage collection:' + item['collection'] App.Store.write( item['collection'], item['data'] ) # fire event if item['event'] if typeof item['event'] is 'object' for event in item['event'] - @log 'debug', "onmessage event:" + event + @log 'debug', 'onmessage event:' + event App.Event.trigger( event, item['data'] ) else - @log 'debug', "onmessage event:" + item['event'] + @log 'debug', 'onmessage event:' + item['event'] App.Event.trigger( item['event'], item['data'] ) _ajaxInit: (data = {}) => diff --git a/app/assets/javascripts/app/lib/spine/ajax.coffee b/app/assets/javascripts/app/lib/spine/ajax.coffee index 740a3bf33..d77daa217 100644 --- a/app/assets/javascripts/app/lib/spine/ajax.coffee +++ b/app/assets/javascripts/app/lib/spine/ajax.coffee @@ -1,4 +1,4 @@ -# coffeelint: disable=no_this,indentation +# coffeelint: disable=no_this,indentation,no_unnecessary_double_quotes Spine = @Spine or require('spine') $ = Spine.$ Model = Spine.Model diff --git a/app/assets/javascripts/app/lib/spine/local.coffee b/app/assets/javascripts/app/lib/spine/local.coffee index 63d2418f8..6dc9ca519 100644 --- a/app/assets/javascripts/app/lib/spine/local.coffee +++ b/app/assets/javascripts/app/lib/spine/local.coffee @@ -1,3 +1,4 @@ +# coffeelint: disable=,arrow_spacing Spine = @Spine or require('spine') Spine.Model.Local = diff --git a/app/assets/javascripts/app/lib/spine/route.coffee b/app/assets/javascripts/app/lib/spine/route.coffee index 6b7091948..481465415 100644 --- a/app/assets/javascripts/app/lib/spine/route.coffee +++ b/app/assets/javascripts/app/lib/spine/route.coffee @@ -1,4 +1,4 @@ -# coffeelint: disable=no_this,indentation +# coffeelint: disable=no_this,indentation,arrow_spacing Spine = @Spine or require('spine') $ = Spine.$ diff --git a/app/assets/javascripts/app/lib/spine/spine.coffee b/app/assets/javascripts/app/lib/spine/spine.coffee index ee8d80e9a..de7d90177 100644 --- a/app/assets/javascripts/app/lib/spine/spine.coffee +++ b/app/assets/javascripts/app/lib/spine/spine.coffee @@ -1,4 +1,4 @@ -# coffeelint: disable=no_this +# coffeelint: disable=no_this,arrow_spacing,no_unnecessary_double_quotes ### Spine.js MVC library Released under the MIT License diff --git a/app/assets/javascripts/app/models/organization.js.coffee b/app/assets/javascripts/app/models/organization.js.coffee index 4d3d2a839..b14c7ce35 100644 --- a/app/assets/javascripts/app/models/organization.js.coffee +++ b/app/assets/javascripts/app/models/organization.js.coffee @@ -42,6 +42,6 @@ Mit **Organisationen** können Sie Kunden **gruppieren**. Dies hat u. a. zwei be searchResultAttributes: -> display: "#{@displayName()}" id: @id - class: "organization organization-popover" + class: 'organization organization-popover' url: @uiUrl() - iconClass: "organization" + iconClass: 'organization' diff --git a/app/assets/javascripts/app/models/ticket.js.coffee b/app/assets/javascripts/app/models/ticket.js.coffee index 85d021aab..c1ab262a1 100644 --- a/app/assets/javascripts/app/models/ticket.js.coffee +++ b/app/assets/javascripts/app/models/ticket.js.coffee @@ -56,4 +56,4 @@ class App.Ticket extends App.Model id: @id class: "level-#{@level()} ticket-popover" url: @uiUrl() - iconClass: "priority" + iconClass: 'priority' diff --git a/app/assets/javascripts/app/models/user.js.coffee b/app/assets/javascripts/app/models/user.js.coffee index b71bd496e..67bf21035 100644 --- a/app/assets/javascripts/app/models/user.js.coffee +++ b/app/assets/javascripts/app/models/user.js.coffee @@ -82,7 +82,7 @@ class App.User extends App.Model vip = false data = "data-id=\"#{@id}\"" else - cssClass += " user-popover" + cssClass += ' user-popover' data = "data-id=\"#{@id}\"" else vip = false @@ -129,6 +129,6 @@ class App.User extends App.Model searchResultAttributes: -> display: "#{@displayName()}" id: @id - class: "user user-popover" + class: 'user user-popover' url: @uiUrl() - iconClass: "user" \ No newline at end of file + iconClass: 'user' diff --git a/coffeelint.json b/coffeelint.json index e60236fbf..548e8e3e5 100644 --- a/coffeelint.json +++ b/coffeelint.json @@ -1,6 +1,6 @@ { "arrow_spacing": { - "level": "ignore" + "level": "error" }, "braces_spacing": { "level": "ignore", @@ -31,7 +31,7 @@ "level": "ignore" }, "ensure_comprehensions": { - "level": "warn" + "level": "error" }, "eol_last": { "level": "ignore" @@ -41,7 +41,7 @@ "level": "error" }, "line_endings": { - "level": "ignore", + "level": "error", "value": "unix" }, "max_line_length": { @@ -61,14 +61,14 @@ "level": "error" }, "no_debugger": { - "level": "warn", + "level": "error", "console": false }, "no_empty_functions": { "level": "ignore" }, "no_empty_param_list": { - "level": "warn" + "level": "error" }, "no_implicit_braces": { "level": "ignore", @@ -79,16 +79,16 @@ "level": "ignore" }, "no_interpolation_in_single_quotes": { - "level": "warn" + "level": "error" }, "no_nested_string_interpolation": { - "level": "warn" + "level": "error" }, "no_plusplus": { "level": "ignore" }, "no_private_function_fat_arrows": { - "level": "warn" + "level": "error" }, "no_stand_alone_at": { "level": "ignore" @@ -97,7 +97,7 @@ "level": "error" }, "no_this": { - "level": "warn" + "level": "error" }, "no_throwing_strings": { "level": "ignore" @@ -111,10 +111,10 @@ "allowed_in_empty_lines": true }, "no_unnecessary_double_quotes": { - "level": "ignore" + "level": "error" }, "no_unnecessary_fat_arrows": { - "level": "warn" + "level": "error" }, "non_empty_constructor_needs_parens": { "level": "ignore" @@ -130,6 +130,6 @@ "level": "ignore" }, "transform_messes_up_line_numbers": { - "level": "warn" + "level": "error" } }