Sutty/trabajo-afectivo
5
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Improved network error handling if ticket is already open.

Browse source
This commit is contained in:
Martin Edenhofer 2015-02-04 08:53:47 +01:00
parent 53d13b20f3
commit e2d2890c6d
1 changed files with 16 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
app/assets/javascripts/app/controllers/ticket_zoom.js.coffee
View file

@ -124,17 +124,27 @@ class App.TicketZoom extends App.Controller
@doNotLog = 1 @doNotLog = 1
@recentView( 'Ticket', ticket_id ) @recentView( 'Ticket', ticket_id )
error: (xhr, status, error) => error: (xhr) =>
statusText = xhr.statusText
status = xhr.status
detail = xhr.responseText
#console.log('error', status, statusText)
# do not close window if request is aborted # ignore if request is aborted
return if status is 'abort' if statusText is 'abort'
return
# if ticket is already loaded, ignore status "0" - network issues e. g. temp. not connection
if @ticketUpdatedAtLastCall && status is 0
console.log('network issues e. g. temp. not connection', status, statusText, detail)
return
# show error message # show error message
if xhr.status is 401 || error is 'Unauthorized' if status is 401 || statusText is 'Unauthorized'
@taskHead = '» ' + App.i18n.translateInline('Unauthorized') + ' «' @taskHead = '» ' + App.i18n.translateInline('Unauthorized') + ' «'
@taskIconClass = 'error' @taskIconClass = 'error'
@html App.view('generic/error/unauthorized')( objectName: 'Ticket' ) @html App.view('generic/error/unauthorized')( objectName: 'Ticket' )
else if xhr.status is 404 || error is 'Not Found' else if status is 404 || statusText is 'Not Found'
@taskHead = '» ' + App.i18n.translateInline('Not Found') + ' «' @taskHead = '» ' + App.i18n.translateInline('Not Found') + ' «'
@taskIconClass = 'error' @taskIconClass = 'error'
@html App.view('generic/error/not_found')( objectName: 'Ticket' ) @html App.view('generic/error/not_found')( objectName: 'Ticket' )
@ -142,9 +152,7 @@ class App.TicketZoom extends App.Controller
@taskHead = '» ' + App.i18n.translateInline('Error') + ' «' @taskHead = '» ' + App.i18n.translateInline('Error') + ' «'
@taskIconClass = 'error' @taskIconClass = 'error'
status = xhr.status if !detail
detail = xhr.responseText
if !status && !detail
detail = 'General communication error, maybe internet is not available!' detail = 'General communication error, maybe internet is not available!'
@html App.view('generic/error/generic')( @html App.view('generic/error/generic')(
status: status status: status