From e33830979108a600c044f5e43ba4cc9fdaec1993 Mon Sep 17 00:00:00 2001
From: Dominik Klein <dk@zammad.com>
Date: Fri, 22 Oct 2021 14:23:31 +0200
Subject: [PATCH] Fixes #3094, fixes #2334 - When quoting, no breakout from div
 container possible.

---
 .../app/lib/base/jquery.contenteditable.js    | 21 ++++++++++++----
 .../ticket/update/full_quote_header_spec.rb   | 25 +++++++++++++++++++
 2 files changed, 41 insertions(+), 5 deletions(-)

diff --git a/app/assets/javascripts/app/lib/base/jquery.contenteditable.js b/app/assets/javascripts/app/lib/base/jquery.contenteditable.js
index 940073406..31ef2c486 100644
--- a/app/assets/javascripts/app/lib/base/jquery.contenteditable.js
+++ b/app/assets/javascripts/app/lib/base/jquery.contenteditable.js
@@ -114,11 +114,22 @@
       sel = window.getSelection()
       if (sel) {
         node = $(sel.anchorNode)
-        if (node && node.parent() && node.parent().is('blockquote')) {
-          e.preventDefault()
-          document.execCommand('Insertparagraph')
-          document.execCommand('Outdent')
-          return
+
+        if (node.closest('blockquote').length > 0) {
+
+          // Special handling when the line is not wrapped inside of a html element.
+          if (!node.is('div') && node.parent().is('blockquote') && node.text()) {
+            e.preventDefault()
+            document.execCommand('formatBlock', false, 'div')
+            document.execCommand('insertParagraph')
+            return
+          }
+          if (!e.shiftKey && node && (node.is('blockquote') || (node.parent() && node.parent().is('blockquote')) || !node.text())) {
+            e.preventDefault()
+            document.execCommand('insertParagraph')
+            document.execCommand('outdent')
+            return
+          }
         }
       }
 
diff --git a/spec/system/ticket/update/full_quote_header_spec.rb b/spec/system/ticket/update/full_quote_header_spec.rb
index b3fd84b6d..95f24fb18 100644
--- a/spec/system/ticket/update/full_quote_header_spec.rb
+++ b/spec/system/ticket/update/full_quote_header_spec.rb
@@ -178,6 +178,31 @@ RSpec.describe 'Ticket > Update > Full Quote Header', current_user_id: -> { curr
       end
     end
 
+    context 'when full quote header setting is enabled' do
+      let(:full_quote_header_setting) { true }
+
+      it 'can breakout with enter from quote block' do
+        within(:active_content) do
+          highlight_and_click_reply
+
+          within(:richtext) do
+            blockquote_empty_line = first('blockquote br:nth-child(2)', visible: :all)
+            page.driver.browser.action.move_to_location(blockquote_empty_line.native.location.x, blockquote_empty_line.native.location.y).click.perform
+          end
+
+          # Special handling for firefox, because the cursor is at the wrong location after the move to with click.
+          if Capybara.current_driver == :zammad_firefox
+            find(:richtext).send_keys(:down)
+          end
+
+          find(:richtext).send_keys(:enter)
+
+          within(:richtext) do
+            expect(page).to have_css('blockquote', count: 2)
+          end
+        end
+      end
+    end
   end
 
   def click_forward