Maintenance: Introduced custom Rubocop Zammad/ExistsConditions to check for .find_by in conditions and replace it with .exists? to increase performance and reduce memory cost.

.rubocop/cop/zammad/exists_condition.rb

@@ -0,0 +1,120 @@
+module RuboCop
+  module Cop
+    module Zammad
+      # This cop is used to identify usages of `find_by` in conditions and
+      # changes them to use `exists?` instead.
+      #
+      # @example
+      #   # bad
+      #   if User.find_by(name: 'Rubocop')
+      #   if !User.find_by(name: 'Rubocop')
+      #   unless User.find_by(name: 'Rubocop')
+      #   if find_by(name: 'Rubocop')
+      #   if !find_by(name: 'Rubocop')
+      #   unless find_by(name: 'Rubocop')
+      #
+      #   # good
+      #   if User.exists?(name: 'Rubocop')
+      #   if !User.exists?(name: 'Rubocop')
+      #   unless User.exists?(name: 'Rubocop')
+      #   if exists?(name: 'Rubocop')
+      #   if !exists?(name: 'Rubocop')
+      #   unless exists?(name: 'Rubocop')
+      class ExistsCondition < Cop
+
+        def_node_matcher :find_by_condition?, <<-PATTERN
+          {
+            $(send $_ :find_by ...)
+            (send $(send $_ :find_by ...) :!)
+          }
+        PATTERN
+
+        MSG = 'Use `%<prefer>s` instead of `%<current>s`.'.freeze
+
+        def on_if(node)
+          check_for_find_by(node)
+        end
+
+        def on_while(node)
+          check_for_find_by(node)
+        end
+
+        def on_while_post(node)
+          check_for_find_by(node)
+        end
+
+        def on_until(node)
+          check_for_find_by(node)
+        end
+
+        def on_until_post(node)
+          check_for_find_by(node)
+        end
+
+        def autocorrect(node)
+          lambda do |corrector|
+            corrector.replace(node.loc.selector, 'exists?')
+          end
+        end
+
+        private
+
+        def check_for_find_by(node)
+          cond = condition(node)
+          handle_node(cond)
+        end
+
+        def check_node(node)
+          return unless node
+
+          if keyword_bang?(node)
+            receiver, = *node
+
+            handle_node(receiver)
+          elsif node.operator_keyword?
+            node.each_child_node { |op| handle_node(op) }
+          elsif node.begin_type? && node.children.one?
+            handle_node(node.children.first)
+          end
+        end
+
+        def keyword_bang?(node)
+          node.respond_to?(:keyword_bang?) && node.keyword_bang?
+        end
+
+        def handle_node(node)
+          if node.send_type?
+            check_offense(*find_by_condition?(node)) # rubocop:disable Rails/DynamicFindBy
+          elsif %i[and or begin].include?(node.type)
+            check_node(node)
+          end
+        end
+
+        def condition(node)
+          if node.send_type?
+            node.receiver
+          else
+            node.condition
+          end
+        end
+
+        def check_offense(method_call = nil, receiver = nil)
+          return if method_call.nil?
+
+          add_offense(method_call,
+                      message: format(MSG,
+                                      prefer:  replacement(receiver),
+                                      current: current(receiver)))
+        end
+
+        def current(node)
+          node.respond_to?(:source) ? "#{node.source}.find_by" : 'find_by'
+        end
+
+        def replacement(node)
+          node.respond_to?(:source) ? "#{node.source}.exists?" : 'exists?'
+        end
+      end
+    end
+  end
+end

.rubocop/default.yml

@@ -5,6 +5,7 @@ require:
   - rubocop-performance
   - rubocop-rails
   - rubocop-rspec
+  - ./rubocop_zammad.rb
 
 inherit_from:
   - todo.yml

.rubocop/rubocop_zammad.rb

@@ -0,0 +1 @@
+require_relative 'cop/zammad/exists_condition'

app/controllers/channels_email_controller.rb

@@ -31,7 +31,7 @@ class ChannelsEmailController < ApplicationController
 
       email_address_ids.push email_address.id
       assets = email_address.assets(assets)
-      if !email_address.channel_id || !email_address.active || !Channel.find_by(id: email_address.channel_id)
+      if !email_address.channel_id || !email_address.active || !Channel.exists?(id: email_address.channel_id)
         not_used_email_address_ids.push email_address.id
       end
     end

app/models/calendar.rb

@@ -360,7 +360,7 @@ returns
 
   # check if min one is set to default true
   def min_one_check
-    if !Calendar.find_by(default: true)
+    if !Calendar.exists?(default: true)
       first = Calendar.order(:created_at, :id).limit(1).first
       return true if !first
 
@@ -376,7 +376,7 @@ returns
         sla.save!
         next
       end
-      if !Calendar.find_by(id: sla.calendar_id)
+      if !Calendar.exists?(id: sla.calendar_id)
         sla.calendar_id = default_calendar.id
         sla.save!
       end

app/models/channel/driver/sms/twilio.rb

@@ -33,7 +33,7 @@ class Channel::Driver::Sms::Twilio
     Rails.logger.info "Receiving SMS frim recipient #{attr[:From]}"
 
     # prevent already created articles
-    if Ticket::Article.find_by(message_id: attr[:SmsMessageSid])
+    if Ticket::Article.exists?(message_id: attr[:SmsMessageSid])
       return ['application/xml; charset=UTF-8;', Twilio::TwiML::MessagingResponse.new.to_s]
     end
 

app/models/channel/driver/twitter.rb

@@ -186,7 +186,7 @@ returns
         end
 
         next if @client.locale_sender?(tweet) && own_tweet_already_imported?(tweet)
-        next if Ticket::Article.find_by(message_id: tweet.id)
+        next if Ticket::Article.exists?(message_id: tweet.id)
         break if @client.tweet_limit_reached(tweet)
 
         @client.to_group(tweet, search[:group_id], @channel)
@@ -202,7 +202,7 @@ returns
     event_time = Time.zone.now
     sleep 4
     12.times do |loop_count|
-      if Ticket::Article.find_by(message_id: tweet.id)
+      if Ticket::Article.exists?(message_id: tweet.id)
         Rails.logger.debug { "Own tweet already imported, skipping tweet #{tweet.id}" }
         return true
       end
@@ -215,7 +215,7 @@ returns
       sleep sleep_time
     end
 
-    if Ticket::Article.find_by(message_id: tweet.id)
+    if Ticket::Article.exists?(message_id: tweet.id)
       Rails.logger.debug { "Own tweet already imported, skipping tweet #{tweet.id}" }
       return true
     end

app/models/channel/filter/identify_sender.rb

@@ -35,7 +35,7 @@ module Channel::Filter::IdentifySender
             items.each do |item|
 
               # skip if recipient is system email
-              next if EmailAddress.find_by(email: item.address.downcase)
+              next if EmailAddress.exists?(email: item.address.downcase)
 
               customer_user = user_create(
                 login:     item.address,

app/models/channel/filter/sender_is_system_address.rb

@@ -19,7 +19,7 @@ module Channel::Filter::SenderIsSystemAddress
 
       items = mail[form].addrs
       items.each do |item|
-        next if !EmailAddress.find_by(email: item.address.downcase)
+        next if !EmailAddress.exists?(email: item.address.downcase)
 
         mail['x-zammad-ticket-create-article-sender'.to_sym] = 'Agent'
         mail['x-zammad-article-sender'.to_sym] = 'Agent'

app/models/email_address.rb

@@ -63,7 +63,7 @@ check and if channel not exists reset configured channels for email addresses
   def check_if_channel_exists_set_inactive
 
     # set to active if channel exists
-    if channel_id && Channel.find_by(id: channel_id)
+    if channel_id && Channel.exists?(id: channel_id)
       self.active = true
       return true
     end

app/models/tag/item.rb

@@ -49,7 +49,7 @@ Tag::Item.rename(
       Tag.where(tag_item_id: old_tag_item.id).each do |tag|
 
         # check if tag already exists on object
-        if Tag.find_by(tag_object_id: tag.tag_object_id, o_id: tag.o_id, tag_item_id: already_existing_tag.id)
+        if Tag.exists?(tag_object_id: tag.tag_object_id, o_id: tag.o_id, tag_item_id: already_existing_tag.id)
           Tag.tag_remove(
             tag_object_id: tag.tag_object_id,
             o_id:          tag.o_id,

app/models/user.rb

@@ -1046,7 +1046,7 @@ try to find correct name
     raise Exceptions::UnprocessableEntity, 'out of office end is required' if out_of_office_end_at.blank?
     raise Exceptions::UnprocessableEntity, 'out of office end is before start' if out_of_office_start_at > out_of_office_end_at
     raise Exceptions::UnprocessableEntity, 'out of office replacement user is required' if out_of_office_replacement_id.blank?
-    raise Exceptions::UnprocessableEntity, 'out of office no such replacement user' if !User.find_by(id: out_of_office_replacement_id)
+    raise Exceptions::UnprocessableEntity, 'out of office no such replacement user' if !User.exists?(id: out_of_office_replacement_id)
 
     true
   end

db/migrate/20150979000001_update_timestamps.rb

@@ -1,7 +1,7 @@
 class UpdateTimestamps < ActiveRecord::Migration[4.2]
   def up
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     # get all models
     Models.all.each_value do |value|

db/migrate/20160217000001_object_manager_update_user.rb

@@ -2,7 +2,7 @@ class ObjectManagerUpdateUser < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     UserInfo.current_user_id = 1
     ObjectManager::Attribute.add(

db/migrate/20160921000001_permission_active.rb.rb

@@ -1,7 +1,7 @@
 class PermissionActive < ActiveRecord::Migration[4.2]
   def up
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     add_column :permissions, :active, :boolean, null: false, default: true
 

db/migrate/20161112000001_organization_domain_based_assignment.rb

@@ -1,7 +1,7 @@
 class OrganizationDomainBasedAssignment < ActiveRecord::Migration[4.2]
   def up
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     add_column :organizations, :domain, :string, limit: 250, null: true, default: ''
     add_column :organizations, :domain_assignment, :boolean, null: false, default: false

db/migrate/20161117000001_job_unable_to_create_issue_432.rb

@@ -1,7 +1,7 @@
 class JobUnableToCreateIssue432 < ActiveRecord::Migration[4.2]
   def up
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     ActiveRecord::Migration.change_table :jobs do |t|
       t.change :timeplan, :string, limit: 2500

db/migrate/20161117000002_ticket_number_generator_issue_427.rb

@@ -1,7 +1,7 @@
 class TicketNumberGeneratorIssue427 < ActiveRecord::Migration[4.2]
   def up
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     setting = Setting.find_by(name: 'ticket_number')
     setting.preferences = {

db/migrate/20161117000003_store_config_name_update_issue_428.rb

@@ -1,7 +1,7 @@
 class StoreConfigNameUpdateIssue428 < ActiveRecord::Migration[4.2]
   def up
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     setting = Setting.find_by(name: 'storage')
     return if !setting

db/migrate/20161122000001_monitoring_issue_453.rb

@@ -1,7 +1,7 @@
 class MonitoringIssue453 < ActiveRecord::Migration[4.2]
   def up
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Monitoring Token',

db/migrate/20161228000001_add_taskbar_meta.rb

@@ -1,7 +1,7 @@
 class AddTaskbarMeta < ActiveRecord::Migration[4.2]
   def up
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     add_column :taskbars, :preferences, :text, limit: 5.megabytes + 1, null: true
     add_index :taskbars, [:key]

db/migrate/20170113000001_object_manager_attribute_create_middle.rb

@@ -1,7 +1,7 @@
 class ObjectManagerAttributeCreateMiddle < ActiveRecord::Migration[4.2]
   def up
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     ObjectManager::Attribute.all.each do |attribute|
       next if attribute.name == 'tags'

db/migrate/20170113000002_slack_group_config_issue_587.rb

@@ -2,7 +2,7 @@ class SlackGroupConfigIssue587 < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     setting = Setting.find_by(name: 'slack_config')
     return if !setting

db/migrate/20170116000001_add_ticket_time_accounting_373.rb

@@ -2,7 +2,7 @@ class AddTicketTimeAccounting373 < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     drop_table :ticket_time_accounting
     create_table :ticket_time_accountings do |t|

db/migrate/20170116000002_fixed_typos_622.rb

@@ -2,7 +2,7 @@ class FixedTypos622 < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     setting = Setting.find_by(name: 'ticket_define_email_from_seperator')
     return if !setting

db/migrate/20170117000001_unable_to_enable_time_accounting_633.rb

@@ -2,7 +2,7 @@ class UnableToEnableTimeAccounting633 < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Time Accounting',

db/migrate/20170119000001_login_email_length_650.rb

@@ -2,7 +2,7 @@ class LoginEmailLength650 < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     change_column(:users, :login, :string, limit: 255)
     change_column(:users, :email, :string, limit: 255)

db/migrate/20170123000001_ui_ticket_zoom_article_new_internal.rb

@@ -2,7 +2,7 @@ class UiTicketZoomArticleNewInternal < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Define default visibility of new a new article',

db/migrate/20170123000002_fixed_translation.rb

@@ -2,7 +2,7 @@ class FixedTranslation < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     settings_update = [
       {

db/migrate/20170126091128_application_secret_setting.rb

@@ -2,7 +2,7 @@ class ApplicationSecretSetting < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Application secret',

db/migrate/20170130000001_follow_up_possible_check_643.rb

@@ -2,7 +2,7 @@ class FollowUpPossibleCheck643 < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Define postmaster filter.',

db/migrate/20170203000001_remove_last_login_from_history_722.rb

@@ -2,7 +2,7 @@ class RemoveLastLoginFromHistory722 < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     history_object = History.object_lookup('User')
     return if !history_object

db/migrate/20170203000003_do_not_import_onw_notifications_731.rb

@@ -2,7 +2,7 @@ class DoNotImportOnwNotifications731 < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Define postmaster filter.',

db/migrate/20170207081400_ticket_state_priority_defaults.rb

@@ -2,7 +2,7 @@ class TicketStatePriorityDefaults < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     add_column :ticket_states, :default_create, :boolean, null: false, default: false
     add_index  :ticket_states, :default_create

db/migrate/20170214000001_reload_online_browser_after_cors_csrf_changes.rb

@@ -2,7 +2,7 @@ class ReloadOnlineBrowserAfterCorsCsrfChanges < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     AppVersion.set(true, 'app_version')
   end

db/migrate/20170215000001_telegram_support.rb

@@ -2,7 +2,7 @@ class TelegramSupport < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Permission.create_if_not_exists(
       name:        'admin.channel_telegram',

db/migrate/20170314000001_fixed_translation2.rb

@@ -2,7 +2,7 @@ class FixedTranslation2 < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     settings_update = [
       {

db/migrate/20170403000001_fixed_admin_user_permission_920.rb

@@ -2,7 +2,7 @@ class FixedAdminUserPermission920 < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     ObjectManager::Attribute.add(
       force:       true,

db/migrate/20170418000001_validate_agent_limit.rb

@@ -1,7 +1,7 @@
 class ValidateAgentLimit < ActiveRecord::Migration[4.2]
   def up
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Set limit of agents',

db/migrate/20170419000001_ldap_support.rb

@@ -2,7 +2,7 @@ class LdapSupport < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     if !ActiveRecord::Base.connection.table_exists? 'import_jobs'
       create_table :import_jobs do |t|

db/migrate/20170419000002_overview_role_ids.rb

@@ -2,7 +2,7 @@ class OverviewRoleIds < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     create_table :overviews_roles, id: false do |t|
       t.integer :overview_id

db/migrate/20170420000001_chat_increase_message_size.rb

@@ -2,7 +2,7 @@ class ChatIncreaseMessageSize < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     change_column :chat_messages, :content, :text, limit: 20.megabytes + 1, null: false
   end

db/migrate/20170421000001_pretty_date_options_added.rb

@@ -2,7 +2,7 @@ class PrettyDateOptionsAdded < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_or_update(
       title:       'Pretty Date',

db/migrate/20170421110000_add_origin_by_id.rb

@@ -2,7 +2,7 @@ class AddOriginById < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     add_column :ticket_articles, :origin_by_id, :integer
   end

db/migrate/20170426135500_add_reply_to.rb

@@ -2,7 +2,7 @@ class AddReplyTo < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     add_column :ticket_articles, :reply_to, :string, limit: 300
   end

db/migrate/20170504144100_follow_up_merged.rb

@@ -2,7 +2,7 @@ class FollowUpMerged < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Defines postmaster filter.',

db/migrate/20170515000001_scheduler_status.rb

@@ -2,7 +2,7 @@ class SchedulerStatus < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     change_table :schedulers do |t|
       t.string :error_message, null: true

db/migrate/20170516000001_trigger_recipient_update.rb

@@ -2,7 +2,7 @@ class TriggerRecipientUpdate < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     ['auto reply (on new tickets)', 'auto reply (on follow-up of tickets)'].each do |name|
 

db/migrate/20170525000001_reply_to_sender_feature.rb

@@ -2,7 +2,7 @@ class ReplyToSenderFeature < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Sender based on Reply-To header',

db/migrate/20170529000002_setting_delivery_permanent_failed.rb

@@ -2,7 +2,7 @@ class SettingDeliveryPermanentFailed < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     setting = Setting.find_by(name: '0900_postmaster_filter_bounce_check')
     if setting

db/migrate/20170529132120_ldap_multi_group_mapping.rb

@@ -2,7 +2,7 @@ class LdapMultiGroupMapping < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     # load existing LDAP config
     ldap_config = Setting.get('ldap_config')

db/migrate/20170531144425_foreign_keys.rb

@@ -4,7 +4,7 @@ class ForeignKeys < ActiveRecord::Migration[4.2]
   def change
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     # remove wrong plural of ID columns
     ActiveRecord::Migration.rename_column :ticket_flags, :tickets_id, :ticket_id

db/migrate/20170608151442_enhanced_permissions.rb

@@ -2,7 +2,7 @@ class EnhancedPermissions < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     change_column_null :groups_users, :user_id, false
     change_column_null :groups_users, :group_id, false

db/migrate/20170619000001_tree_select.rb

@@ -2,7 +2,7 @@ class TreeSelect < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     change_column :object_manager_attributes, :data_option, :text, limit: 800.kilobytes + 1, null: true
     change_column :object_manager_attributes, :data_option_new, :text, limit: 800.kilobytes + 1, null: true

db/migrate/20170626000001_locale_add_direction.rb

@@ -2,7 +2,7 @@ class LocaleAddDirection < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     add_column :locales, :dir, :string, limit: 9, null: false, default: 'ltr'
   end

db/migrate/20170628000001_form_group_selection.rb

@@ -2,7 +2,7 @@ class FormGroupSelection < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     group = Group.where(active: true).first
     if !group

db/migrate/20170629000001_exchange_integration.rb

@@ -2,7 +2,7 @@ class ExchangeIntegration < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.set('import_backends', ['Import::Ldap', 'Import::Exchange'])
 

db/migrate/20170713000001_omniauth_office365_setting.rb

@@ -2,7 +2,7 @@ class OmniauthOffice365Setting < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Authentication via %s',

db/migrate/20170713000002_ticket_zoom_setting2.rb

@@ -2,7 +2,7 @@ class TicketZoomSetting2 < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     setting = Setting.find_by(name: 'ui_ticket_zoom_article_new_internal')
     if setting

db/migrate/20170714000001_object_manager_user_email_optional.rb

@@ -2,7 +2,7 @@ class ObjectManagerUserEmailOptional < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     ObjectManager::Attribute.add(
       force:       true,

db/migrate/20170714000002_user_email_multiple_use.rb

@@ -2,7 +2,7 @@ class UserEmailMultipleUse < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'User email for muliple users',

db/migrate/20170714000003_cleanup_cti_log.rb

@@ -2,7 +2,7 @@ class CleanupCtiLog < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Scheduler.create_if_not_exists(
       name:          'Cleanup Cti::Log',

db/migrate/20170727000001_setting_proxy.rb

@@ -2,7 +2,7 @@ class SettingProxy < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Proxy Settings',

db/migrate/20170816000001_idoit_support.rb

@@ -2,7 +2,7 @@ class IdoitSupport < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'i-doit integration',

db/migrate/20170822000001_agend_based_sender_issue_1351.rb

@@ -2,7 +2,7 @@ class AgendBasedSenderIssue1351 < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     EmailAddress.all.each do |email_address|
 

db/migrate/20170910000002_out_of_office2.rb

@@ -2,7 +2,7 @@ class OutOfOffice2 < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     if !ActiveRecord::Base.connection.column_exists?(:overviews, :out_of_office)
       add_column :overviews, :out_of_office, :boolean, null: false, default: false

db/migrate/20170924054554_weibo_oauth2.rb

@@ -2,7 +2,7 @@ class WeiboOauth2 < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Authentication via %s',

db/migrate/20170927000001_setting_send_no_auto_response_reg_exp.rb

@@ -2,10 +2,10 @@ class SettingSendNoAutoResponseRegExp < ActiveRecord::Migration[5.0]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     # improved domain name matching
-    return if !Setting.find_by(name: 'send_no_auto_response_reg_exp')
+    return if !Setting.exists?(name: 'send_no_auto_response_reg_exp')
 
     Setting.set('send_no_auto_response_reg_exp', '(mailer-daemon|postmaster|abuse|root|noreply|noreply.+?|no-reply|no-reply.+?)@.+?')
   end

db/migrate/20171002091043_change_note_char_limit_for_users_and_organizations.rb

@@ -1,7 +1,7 @@
 class ChangeNoteCharLimitForUsersAndOrganizations < ActiveRecord::Migration[5.1]
   def up
     # return if it's a new setup to avoid running the migration
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     change_column :organizations, :note, :string, limit: 5000
     change_column :users, :note, :string, limit: 5000

db/migrate/20171023000001_fixed_store_upgrade_ror_45.rb

@@ -2,7 +2,7 @@ class FixedStoreUpgradeRor45 < ActiveRecord::Migration[5.0]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Cache.clear
     [Macro, Taskbar, Calendar, Trigger, Channel, Job, PostmasterFilter, Report::Profile, Setting, Sla, Template].each do |class_name|

db/migrate/20171024000001_monit_integration.rb

@@ -2,7 +2,7 @@ class MonitIntegration < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Monit integration',

db/migrate/20171024000002_check_mk_integration2.rb

@@ -2,7 +2,7 @@ class CheckMkIntegration2 < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Check_MK integration',

db/migrate/20171102000001_last_owner_update2.rb

@@ -2,7 +2,7 @@ class LastOwnerUpdate2 < ActiveRecord::Migration[5.1]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     # reset assignment_timeout to prevent unwanted things happen
     Group.all.each do |group|

db/migrate/20171123000001_email_process_customer_selection_based_on_sender_recipient.rb

@@ -2,7 +2,7 @@ class EmailProcessCustomerSelectionBasedOnSenderRecipient < ActiveRecord::Migrat
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Customer selection based on sender and receiver list',

db/migrate/20171203000001_setting_es_pipeline.rb

@@ -2,7 +2,7 @@ class SettingEsPipeline < ActiveRecord::Migration[5.1]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Elasticsearch Pipeline Name',

db/migrate/20171206000001_setting_default_locale2.rb

@@ -2,7 +2,7 @@ class SettingDefaultLocale2 < ActiveRecord::Migration[5.1]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     setting = Setting.find_by(name: 'locale_default')
     if setting

db/migrate/20171207000001_permission_user_preferences_out_of_office.rb

@@ -2,7 +2,7 @@ class PermissionUserPreferencesOutOfOffice < ActiveRecord::Migration[5.1]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Permission.create_if_not_exists(
       name:        'user_preferences.out_of_office',

db/migrate/20171213000001_change_authorization_token_size.rb

@@ -1,7 +1,7 @@
 class ChangeAuthorizationTokenSize < ActiveRecord::Migration[5.1]
   def up
     # return if it's a new setup to avoid running the migration
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     change_column :authorizations, :token, :string, limit: 2500
 

db/migrate/20180108000001_change_exchange_external_sync_identifier.rb

@@ -1,7 +1,7 @@
 class ChangeExchangeExternalSyncIdentifier < ActiveRecord::Migration[5.1]
   def up
     # return if it's a new setup to avoid running the migration
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     ExternalSync.where(
       source: 'EWS::FolderContact'

db/migrate/20180111000001_ldap_samaccountname_to_uid.rb

@@ -2,7 +2,7 @@ class LdapSamaccountnameToUid < ActiveRecord::Migration[5.1]
 
   def up
     # return if it's a new setup to avoid running the migration
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Delayed::Job.enqueue MigrationJob::LdapSamaccountnameToUid.new
   end

db/migrate/20180116000001_setting_ticket_number_ignore_system_id_support.rb

@@ -2,7 +2,7 @@ class SettingTicketNumberIgnoreSystemIdSupport < ActiveRecord::Migration[4.2]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Ticket Number ignore system_id',

db/migrate/20180128000001_chat_add_ip_country.rb

@@ -2,7 +2,7 @@ class ChatAddIpCountry < ActiveRecord::Migration[5.1]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     add_column :chats, :block_ip, :string, limit: 5000, null: true
     add_column :chats, :block_country, :string, limit: 5000, null: true

db/migrate/20180202000001_sidebar_customer_open_ticket_colored.rb

@@ -2,7 +2,7 @@ class SidebarCustomerOpenTicketColored < ActiveRecord::Migration[5.1]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Open ticket indicator',

db/migrate/20180202000002_custom_ldap_login_attribute.rb

@@ -2,7 +2,7 @@ class CustomLdapLoginAttribute < ActiveRecord::Migration[5.1]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
     return if no_change_needed?
 
     perform_changes

db/migrate/20180220000001_setting_attachment_preview.rb

@@ -2,7 +2,7 @@ class SettingAttachmentPreview < ActiveRecord::Migration[5.1]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Sidebar Attachments',

db/migrate/20180220000002_setting_user_organization_selector_with_email.rb

@@ -2,7 +2,7 @@ class SettingUserOrganizationSelectorWithEmail < ActiveRecord::Migration[5.1]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'User Organization Selector - email',

db/migrate/20180220171219_check_for_object_attributes.rb

@@ -1,6 +1,6 @@
 class CheckForObjectAttributes < ActiveRecord::Migration[5.1]
   def change
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     attributes.each do |attribute|
 

db/migrate/20180226085743_issue_1660_fix_tree_select_configurations.rb

@@ -2,7 +2,7 @@ class Issue1660FixTreeSelectConfigurations < ActiveRecord::Migration[5.1]
   def change
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     return if attributes.blank?
 

db/migrate/20180306084119_custom_html_email_css_font.rb

@@ -2,7 +2,7 @@ class CustomHtmlEmailCssFont < ActiveRecord::Migration[5.1]
   def change
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'HTML Email CSS Font',

db/migrate/20180320000001_setting_table_group_by_show_count.rb

@@ -2,7 +2,7 @@ class SettingTableGroupByShowCount < ActiveRecord::Migration[5.1]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Open ticket indicator',

db/migrate/20180327170847_issue_1905_exchange_login_from_remote_id.rb

@@ -2,7 +2,7 @@ class Issue1905ExchangeLoginFromRemoteId < ActiveRecord::Migration[5.1]
   def change
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     config = Import::Exchange.config
     return if config.blank?

db/migrate/20180418000001_setting_third_party_link_account_at_login.rb

@@ -2,7 +2,7 @@ class SettingThirdPartyLinkAccountAtLogin < ActiveRecord::Migration[5.1]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Automatic account link on initial logon',

db/migrate/20180426134922_issue_1977_remove_invalid_user_foreign_keys.rb

@@ -2,7 +2,7 @@ class Issue1977RemoveInvalidUserForeignKeys < ActiveRecord::Migration[5.1]
   def change
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     # cleanup
     OnlineNotification.joins('LEFT OUTER JOIN users ON online_notifications.user_id = users.id')

db/migrate/20180502015927_issue_1219_zhtw_locale_typo.rb

@@ -3,7 +3,7 @@ class Issue1219ZhtwLocaleTypo < ActiveRecord::Migration[5.1]
   APPLICABLE_VERSION = Gem::Version.new('2.5.0')
 
   def up
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
     return if CURRENT_VERSION < APPLICABLE_VERSION
 
     if Locale.exists?(locale: 'zh-tw')
@@ -20,7 +20,7 @@ class Issue1219ZhtwLocaleTypo < ActiveRecord::Migration[5.1]
   end
 
   def down
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
     return if CURRENT_VERSION >= APPLICABLE_VERSION
 
     if Locale.exists?(locale: 'zj-tw')

db/migrate/20180508182850_ticket_create_types_setting_issue_1987.rb

@@ -1,7 +1,7 @@
 class TicketCreateTypesSettingIssue1987 < ActiveRecord::Migration[5.1]
   def up
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Default type for a new ticket',

db/migrate/20180518000001_issue2029_sipgate_integration_enable.rb

@@ -2,7 +2,7 @@ class Issue2029SipgateIntegrationEnable < ActiveRecord::Migration[5.1]
   def change
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     return if Setting.get('sipgate_config').present?
 

db/migrate/20180518100316_email_forward_prefix_setting_issue_1730.rb

@@ -1,7 +1,7 @@
 class EmailForwardPrefixSettingIssue1730 < ActiveRecord::Migration[5.1]
   def up
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Ticket Subject Forward',

db/migrate/20180521141004_ticket_last_contact_behavior.rb

@@ -1,7 +1,7 @@
 class TicketLastContactBehavior < ActiveRecord::Migration[5.1]
   def up
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Ticket Last Contact Behaviour',

db/migrate/20180524182518_sms_support.rb

@@ -2,7 +2,7 @@ class SmsSupport < ActiveRecord::Migration[5.1]
   def up
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Permission.create_if_not_exists(
       name:        'admin.channel_sms',

db/migrate/20180529000001_issue_2035_recursive_ticket_trigger.rb

@@ -2,7 +2,7 @@ class Issue2035RecursiveTicketTrigger < ActiveRecord::Migration[5.1]
   def change
 
     # return if it's a new setup
-    return if !Setting.find_by(name: 'system_init_done')
+    return if !Setting.exists?(name: 'system_init_done')
 
     Setting.create_if_not_exists(
       title:       'Recursive Ticket Triggers',