Sutty/trabajo-afectivo
5
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fixed issue #2279 - performance issue in bulk action selection in overview (fixes #2279)

Browse source
This commit is contained in:
Billy Zhou 2018-10-17 10:19:19 +02:00
parent 5b38c9e546
commit fb24de11cc
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
app/assets/javascripts/app/controllers/_application_controller_table.coffee
View file

@ -412,6 +412,12 @@ class App.ControllerTable extends App.Controller
return if !@bindCheckbox return if !@bindCheckbox
return if !@bindCheckbox.events return if !@bindCheckbox.events
return if _.isEmpty(clicks) return if _.isEmpty(clicks)
# If a select_all callback exists, then trigger it once insteading of triggering the callback once for each checkbox
if @bindCheckbox.select_all
@bindCheckbox.select_all(clicks[0]..., e)
return
for event, callback of @bindCheckbox.events for event, callback of @bindCheckbox.events
if event == 'click' || event == 'change' if event == 'click' || event == 'change'
for click in clicks for click in clicks
@ -1007,4 +1013,4 @@ class App.ControllerTable extends App.Controller
for position in [0..array1.length-1] for position in [0..array1.length-1]
if array1[position] isnt array2[position] if array1[position] isnt array2[position]
return position return position
true true

1
app/assets/javascripts/app/controllers/ticket_overview.coffee
View file

@ -1175,6 +1175,7 @@ class Table extends App.Controller
bindCheckbox: bindCheckbox:
events: events:
'click': callbackCheckbox 'click': callbackCheckbox
select_all: callbackCheckbox
) )
@renderPopovers() @renderPopovers()