Sutty/trabajo-afectivo
5
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Maintenance: Added new merge request templates for a new tech stack core and normal application feature.

Browse source
This commit is contained in:
Dominik Klein 2021-10-22 13:36:38 +02:00 committed by Martin Gruner
parent a3aa9fa337
commit fff31fc6fb
2 changed files with 40 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
.gitlab/merge_request_templates/new_tech_stack_application_feature.md Normal file
View file

@ -0,0 +1,23 @@
## What does this MR do?
<!--Insert the link to a Asana card in (), or describe the task/changec if there is no related task (but normally there should be always a referenced task) -->
[Asana Task Link]()
## ToDo Checklist
- [ ] Checked that the needed functionality is not already available in a common component.
- [ ] Checked if newly created components can be added in a common way (e.g. common component).
- [ ] Created or changed story for common component.
- [ ] Covered common component with Jest-Test
- [ ] Checked that i didn't add a API request inside of a common component.
- [ ] Covered new functionality with Jest-Test(*)
- [ ] When relevant: Covered new GraphQL (Mutation/Query) with a request test.
(*) Jest tests are normally only needed for the common components or other typescript functionality, because the other functionality will be tested with selenium tests and own GraphQL-API tests (with this we avoid that we need always to mock the graphql calls). But for sure special frontend handling should also be tested with a jest test.
## QA Checklist (to be filled by the reviewer)
- [ ] Implementation satisfies specification
- [ ] Changes confirmed by manual testing
- [ ] [Code style](https://git.znuny.com/zammad/zammad/-/wikis/Coding-style-guide) is appropriate
- [ ] Code is properly covered with tests

17
.gitlab/merge_request_templates/new_tech_stack_core_feature.md Normal file
View file

@ -0,0 +1,17 @@
## What does this MR do?
<!--Insert the link to a Asana card in (), or describe the task/changec if there is no related task (but normally there should be always a referenced task) -->
[Asana Task Link]()
## ToDo Checklist
- [ ] Checked that the feature will also work in the scope of packages.
- [ ] Added comments for "special" core code parts.
- [ ] Added the feature in the "developer manual" with some clear explanation and examples for the usage.
## QA Checklist (to be filled by the reviewer)
- [ ] Implementation satisfies specification
- [ ] Changes confirmed by manual testing
- [ ] [Code style](https://git.znuny.com/zammad/zammad/-/wikis/Coding-style-guide) is appropriate
- [ ] Code is properly covered with tests