require 'rails_helper' require 'models/application_model_examples' require 'models/concerns/can_be_imported_examples' require 'models/concerns/can_csv_import_examples' require 'models/concerns/has_history_examples' require 'models/concerns/has_tags_examples' require 'models/concerns/has_taskbars_examples' require 'models/concerns/has_xss_sanitized_note_examples' require 'models/concerns/has_object_manager_attributes_validation_examples' RSpec.describe Ticket, type: :model do subject(:ticket) { create(:ticket) } it_behaves_like 'ApplicationModel' it_behaves_like 'CanBeImported' it_behaves_like 'CanCsvImport' it_behaves_like 'HasHistory', history_relation_object: 'Ticket::Article' it_behaves_like 'HasTags' it_behaves_like 'HasTaskbars' it_behaves_like 'HasXssSanitizedNote', model_factory: :ticket it_behaves_like 'HasObjectManagerAttributesValidation' describe 'Class methods:' do describe '.selectors' do # https://github.com/zammad/zammad/issues/1769 context 'when matching multiple tickets, each with multiple articles' do let(:tickets) { create_list(:ticket, 2) } before do create(:ticket_article, ticket: tickets.first, from: 'asdf1@blubselector.de') create(:ticket_article, ticket: tickets.first, from: 'asdf2@blubselector.de') create(:ticket_article, ticket: tickets.first, from: 'asdf3@blubselector.de') create(:ticket_article, ticket: tickets.last, from: 'asdf4@blubselector.de') create(:ticket_article, ticket: tickets.last, from: 'asdf5@blubselector.de') create(:ticket_article, ticket: tickets.last, from: 'asdf6@blubselector.de') end let(:condition) do { 'article.from' => { operator: 'contains', value: 'blubselector.de', }, } end it 'returns a list of unique tickets (i.e., no duplicates)' do expect(described_class.selectors(condition, limit: 100, access: 'full')) .to match_array([2, tickets.to_a]) end end end end describe 'Instance methods:' do describe '#merge_to' do let(:target_ticket) { create(:ticket) } context 'when source ticket has Links' do let(:linked_tickets) { create_list(:ticket, 3) } let(:links) { linked_tickets.map { |l| create(:link, from: ticket, to: l) } } it 'reassigns all links to the target ticket after merge' do expect { ticket.merge_to(ticket_id: target_ticket.id, user_id: 1) } .to change { links.each(&:reload).map(&:link_object_source_value) } .to(Array.new(3) { target_ticket.id }) end end context 'when attempting to cross-merge (i.e., to merge B → A after merging A → B)' do before { target_ticket.merge_to(ticket_id: ticket.id, user_id: 1) } it 'raises an error' do expect { ticket.merge_to(ticket_id: target_ticket.id, user_id: 1) } .to raise_error('ticket already merged, no merge into merged ticket possible') end end context 'when attempting to self-merge (i.e., to merge A → A)' do it 'raises an error' do expect { ticket.merge_to(ticket_id: ticket.id, user_id: 1) } .to raise_error("Can't merge ticket with it self!") end end context 'when merging' do let(:merge_user) { create(:user) } before do # create target ticket early # to avoid a race condition # when creating the history entries target_ticket travel 5.minutes ticket.merge_to(ticket_id: target_ticket.id, user_id: merge_user.id) end # Issue #2469 - Add information "Ticket merged" to History it 'creates history entries in both the origin ticket and the target ticket' do expect(target_ticket.history_get.size).to eq 2 target_history = target_ticket.history_get.last expect(target_history['object']).to eq 'Ticket' expect(target_history['type']).to eq 'received_merge' expect(target_history['created_by_id']).to eq merge_user.id expect(target_history['o_id']).to eq target_ticket.id expect(target_history['id_to']).to eq target_ticket.id expect(target_history['id_from']).to eq ticket.id expect(ticket.history_get.size).to eq 4 origin_history = ticket.reload.history_get[1] expect(origin_history['object']).to eq 'Ticket' expect(origin_history['type']).to eq 'merged_into' expect(origin_history['created_by_id']).to eq merge_user.id expect(origin_history['o_id']).to eq ticket.id expect(origin_history['id_to']).to eq target_ticket.id expect(origin_history['id_from']).to eq ticket.id end it 'sends ExternalSync.migrate' do allow(ExternalSync).to receive(:migrate) ticket.merge_to(ticket_id: target_ticket.id, user_id: merge_user.id) expect(ExternalSync).to have_received(:migrate).with('Ticket', ticket.id, target_ticket.id) end # Issue #2960 - Ticket removal of merged / linked tickets doesn't remove references context 'and deleting the origin ticket' do it 'adds reference number and title to the target ticket' do expect { ticket.destroy } .to change { target_ticket.history_get.find { |elem| elem.fetch('type') == 'received_merge' }['value_from'] } .to("##{ticket.number} #{ticket.title}") end end # Issue #2960 - Ticket removal of merged / linked tickets doesn't remove references context 'and deleting the target ticket' do it 'adds reference number and title to the origin ticket' do expect { target_ticket.destroy } .to change { ticket.history_get.find { |elem| elem.fetch('type') == 'merged_into' }['value_to'] } .to("##{target_ticket.number} #{target_ticket.title}") end end end end describe '#perform_changes' do # a `performable` can be a Trigger or a Job # we use DuckTyping and expect that a performable # implements the following interface let(:performable) { OpenStruct.new(id: 1, perform: perform) } # Regression test for https://github.com/zammad/zammad/issues/2001 describe 'argument handling' do let(:perform) do { 'notification.email' => { body: "Hello \#{ticket.customer.firstname} \#{ticket.customer.lastname},", recipient: %w[article_last_sender ticket_owner ticket_customer ticket_agents], subject: "Autoclose (\#{ticket.title})" } } end it 'does not mutate contents of "perform" hash' do expect { ticket.perform_changes(performable, 'trigger', {}, 1) } .not_to change { perform } end end context 'with "ticket.state_id" key in "perform" hash' do let(:perform) do { 'ticket.state_id' => { 'value' => Ticket::State.lookup(name: 'closed').id } } end it 'changes #state to specified value' do expect { ticket.perform_changes(performable, 'trigger', ticket, User.first) } .to change { ticket.reload.state.name }.to('closed') end end # Test for backwards compatibility after PR https://github.com/zammad/zammad/pull/2862 context 'with "pending_time" => { "value": DATE } in "perform" hash' do let(:perform) do { 'ticket.state_id' => { 'value' => Ticket::State.lookup(name: 'pending reminder').id.to_s }, 'ticket.pending_time' => { 'value' => timestamp, }, } end let(:timestamp) { Time.zone.now } it 'changes pending date to given date' do freeze_time do expect { ticket.perform_changes(performable, 'trigger', ticket, User.first) } .to change(ticket, :pending_time).to(be_within(1.minute).of(timestamp)) end end end # Test for PR https://github.com/zammad/zammad/pull/2862 context 'with "pending_time" => { "operator": "relative" } in "perform" hash' do shared_examples 'verify' do it 'verify relative pending time rule' do freeze_time do interval = relative_value.send(relative_range).from_now expect { ticket.perform_changes(performable, 'trigger', ticket, User.first) } .to change(ticket, :pending_time).to(be_within(1.minute).of(interval)) end end end let(:perform) do { 'ticket.state_id' => { 'value' => Ticket::State.lookup(name: 'pending reminder').id.to_s }, 'ticket.pending_time' => { 'operator' => 'relative', 'value' => relative_value, 'range' => relative_range_config }, } end let(:relative_range_config) { relative_range.to_s.singularize } context 'and value in days' do let(:relative_value) { 2 } let(:relative_range) { :days } include_examples 'verify' end context 'and value in minutes' do let(:relative_value) { 60 } let(:relative_range) { :minutes } include_examples 'verify' end end context 'with "ticket.action" => { "value" => "delete" } in "perform" hash' do let(:perform) do { 'ticket.state_id' => { 'value' => Ticket::State.lookup(name: 'closed').id.to_s }, 'ticket.action' => { 'value' => 'delete' }, } end it 'performs a ticket deletion on a ticket' do expect { ticket.perform_changes(performable, 'trigger', ticket, User.first) } .to change(ticket, :destroyed?).to(true) end end context 'with a "notification.email" trigger' do # Regression test for https://github.com/zammad/zammad/issues/1543 # # If a new article fires an email notification trigger, # and then another article is added to the same ticket # before that trigger is performed, # the email template's 'article' var should refer to the originating article, # not the newest one. # # (This occurs whenever one action fires multiple email notification triggers.) context 'when two articles are created before the trigger fires once (race condition)' do let!(:article) { create(:ticket_article, ticket: ticket) } let!(:new_article) { create(:ticket_article, ticket: ticket) } let(:trigger) do build(:trigger, perform: { 'notification.email' => { body: '', recipient: 'ticket_customer', subject: '' } }) end # required by Ticket#perform_changes for email notifications before { article.ticket.group.update(email_address: create(:email_address)) } it 'passes the first article to NotificationFactory::Mailer' do expect(NotificationFactory::Mailer) .to receive(:template) .with(hash_including(objects: { ticket: ticket, article: article })) .at_least(:once) .and_call_original expect(NotificationFactory::Mailer) .not_to receive(:template) .with(hash_including(objects: { ticket: ticket, article: new_article })) ticket.perform_changes(trigger, 'trigger', { article_id: article.id }, 1) end end end context 'with a notification trigger' do # https://github.com/zammad/zammad/issues/2782 # # Notification triggers should log notification as private or public # according to given configuration let(:user) { create(:admin, mobile: '+37061010000') } before { ticket.group.users << user } let(:perform) do { notification_key => { body: 'Old programmers never die. They just branch to a new address.', recipient: 'ticket_agents', subject: 'Old programmers never die. They just branch to a new address.' } }.deep_merge(additional_options).deep_stringify_keys end let(:notification_key) { "notification.#{notification_type}" } shared_examples 'verify log visibility status' do shared_examples 'notification trigger' do it 'adds Ticket::Article' do expect { ticket.perform_changes(performable, 'trigger', ticket, user) } .to change { ticket.articles.count }.by(1) end it 'new Ticket::Article visibility reflects setting' do ticket.perform_changes(performable, 'trigger', ticket, User.first) new_article = ticket.articles.reload.last expect(new_article.internal).to be target_internal_value end end context 'when set to private' do let(:additional_options) do { notification_key => { internal: true } } end let(:target_internal_value) { true } it_behaves_like 'notification trigger' end context 'when set to internal' do let(:additional_options) do { notification_key => { internal: false } } end let(:target_internal_value) { false } it_behaves_like 'notification trigger' end context 'when no selection was made' do # ensure previously created triggers default to public let(:additional_options) do {} end let(:target_internal_value) { false } it_behaves_like 'notification trigger' end end context 'dispatching email' do let(:notification_type) { :email } include_examples 'verify log visibility status' end context 'dispatching SMS' do let(:notification_type) { :sms } before { create(:channel, area: 'Sms::Notification') } include_examples 'verify log visibility status' end end end describe '#subject_build' do context 'with default "ticket_hook_position" setting ("right")' do it 'returns the given string followed by a ticket reference (of the form "[Ticket#123]")' do expect(ticket.subject_build('foo')) .to eq("foo [Ticket##{ticket.number}]") end context 'and a non-default value for the "ticket_hook" setting' do before { Setting.set('ticket_hook', 'bar baz') } it 'replaces "Ticket#" with the new ticket hook' do expect(ticket.subject_build('foo')) .to eq("foo [bar baz#{ticket.number}]") end end context 'and a non-default value for the "ticket_hook_divider" setting' do before { Setting.set('ticket_hook_divider', ': ') } it 'inserts the new ticket hook divider between "Ticket#" and the ticket number' do expect(ticket.subject_build('foo')) .to eq("foo [Ticket#: #{ticket.number}]") end end context 'when the given string already contains a ticket reference, but in the wrong place' do it 'moves the ticket reference to the end' do expect(ticket.subject_build("[Ticket##{ticket.number}] foo")) .to eq("foo [Ticket##{ticket.number}]") end end context 'when the given string already contains an alternately formatted ticket reference' do it 'reformats the ticket reference' do expect(ticket.subject_build("foo [Ticket#: #{ticket.number}]")) .to eq("foo [Ticket##{ticket.number}]") end end end context 'with alternate "ticket_hook_position" setting ("left")' do before { Setting.set('ticket_hook_position', 'left') } it 'returns a ticket reference (of the form "[Ticket#123]") followed by the given string' do expect(ticket.subject_build('foo')) .to eq("[Ticket##{ticket.number}] foo") end context 'and a non-default value for the "ticket_hook" setting' do before { Setting.set('ticket_hook', 'bar baz') } it 'replaces "Ticket#" with the new ticket hook' do expect(ticket.subject_build('foo')) .to eq("[bar baz#{ticket.number}] foo") end end context 'and a non-default value for the "ticket_hook_divider" setting' do before { Setting.set('ticket_hook_divider', ': ') } it 'inserts the new ticket hook divider between "Ticket#" and the ticket number' do expect(ticket.subject_build('foo')) .to eq("[Ticket#: #{ticket.number}] foo") end end context 'when the given string already contains a ticket reference, but in the wrong place' do it 'moves the ticket reference to the start' do expect(ticket.subject_build("foo [Ticket##{ticket.number}]")) .to eq("[Ticket##{ticket.number}] foo") end end context 'when the given string already contains an alternately formatted ticket reference' do it 'reformats the ticket reference' do expect(ticket.subject_build("[Ticket#: #{ticket.number}] foo")) .to eq("[Ticket##{ticket.number}] foo") end end end end end describe 'Attributes:' do describe '#owner' do let(:original_owner) { create(:agent, groups: [ticket.group]) } before { ticket.update(owner: original_owner) } context 'when assigned directly' do context 'to an active agent belonging to ticket.group' do let(:agent) { create(:agent, groups: [ticket.group]) } it 'can be set' do expect { ticket.update(owner: agent) } .to change { ticket.reload.owner }.to(agent) end end context 'to an agent not belonging to ticket.group' do let(:agent) { create(:agent, groups: [other_group]) } let(:other_group) { create(:group) } it 'resets to default user (id: 1) instead' do expect { ticket.update(owner: agent) } .to change { ticket.reload.owner }.to(User.first) end end context 'to an inactive agent' do let(:agent) { create(:agent, groups: [ticket.group], active: false) } it 'resets to default user (id: 1) instead' do expect { ticket.update(owner: agent) } .to change { ticket.reload.owner }.to(User.first) end end context 'to a non-agent' do let(:agent) { create(:customer, groups: [ticket.group]) } it 'resets to default user (id: 1) instead' do expect { ticket.update(owner: agent) } .to change { ticket.reload.owner }.to(User.first) end end end context 'when the ticket is updated for any other reason' do context 'if original owner is still an active agent belonging to ticket.group' do it 'does not change' do expect { create(:ticket_article, ticket: ticket) } .not_to change { ticket.reload.owner } end end context 'if original owner has left ticket.group' do before { original_owner.groups = [] } it 'resets to default user (id: 1)' do expect { create(:ticket_article, ticket: ticket) } .to change { ticket.reload.owner }.to(User.first) end end context 'if original owner has become inactive' do before { original_owner.update(active: false) } it 'resets to default user (id: 1)' do expect { create(:ticket_article, ticket: ticket) } .to change { ticket.reload.owner }.to(User.first) end end context 'if original owner has lost agent status' do before { original_owner.roles = [create(:role)] } it 'resets to default user (id: 1)' do expect { create(:ticket_article, ticket: ticket) } .to change { ticket.reload.owner }.to(User.first) end end context 'when the Ticket is closed' do before do ticket.update!(state: Ticket::State.lookup(name: 'closed')) end context 'if original owner is still an active agent belonging to ticket.group' do it 'does not change' do expect { create(:ticket_article, ticket: ticket) } .not_to change { ticket.reload.owner } end end context 'if original owner has left ticket.group' do before { original_owner.groups = [] } it 'does not change' do expect { create(:ticket_article, ticket: ticket) } .not_to change { ticket.reload.owner } end end context 'if original owner has become inactive' do before { original_owner.update(active: false) } it 'does not change' do expect { create(:ticket_article, ticket: ticket) } .not_to change { ticket.reload.owner } end end context 'if original owner has lost agent status' do before { original_owner.roles = [create(:role)] } it 'does not change' do expect { create(:ticket_article, ticket: ticket) } .not_to change { ticket.reload.owner } end end end end end describe '#state' do context 'when originally "new" (default)' do context 'and a customer article is added' do let(:article) { create(:ticket_article, ticket: ticket, sender_name: 'Customer') } it 'stays "new"' do expect { article } .not_to change { ticket.state.name }.from('new') end end context 'and a non-customer article is added' do let(:article) { create(:ticket_article, ticket: ticket, sender_name: 'Agent') } it 'switches to "open"' do expect { article } .to change { ticket.reload.state.name }.from('new').to('open') end end end context 'when originally "closed"' do before { ticket.update(state: Ticket::State.find_by(name: 'closed')) } context 'when a non-customer article is added' do let(:article) { create(:ticket_article, ticket: ticket, sender_name: 'Agent') } it 'stays "closed"' do expect { article }.not_to change { ticket.reload.state.name } end end end end describe '#pending_time' do subject(:ticket) { create(:ticket, pending_time: Time.zone.now + 2.days) } context 'when #state is updated to any non-"pending" value' do it 'is reset to nil' do expect { ticket.update!(state: Ticket::State.lookup(name: 'open')) } .to change(ticket, :pending_time).to(nil) end end # Regression test for commit 92f227786f298bad1ccaf92d4478a7062ea6a49f context 'when #state is updated to nil (violating DB NOT NULL constraint)' do it 'does not prematurely raise within the callback (#reset_pending_time)' do expect { ticket.update!(state: nil) } .to raise_error(ActiveRecord::StatementInvalid) end end end describe '#escalation_at' do before { travel_to(Time.current) } # freeze time let(:sla) { create(:sla, calendar: calendar, first_response_time: 60, update_time: 180, solution_time: 240) } let(:calendar) { create(:calendar, :'24/7') } context 'with no SLAs in the system' do it 'defaults to nil' do expect(ticket.escalation_at).to be(nil) end end context 'with an SLA in the system' do before { sla } # create sla it 'is set based on SLA’s #first_response_time' do expect(ticket.reload.escalation_at.to_i) .to eq(1.hour.from_now.to_i) end context 'after first agent’s response' do before { ticket } # create ticket let(:article) { create(:ticket_article, ticket: ticket, sender_name: 'Agent') } it 'is updated based on the SLA’s #update_time' do travel(1.minute) # time is frozen: if we don't travel forward, pre- and post-update values will be the same expect { article } .to change { ticket.reload.escalation_at.to_i } .to eq(3.hours.from_now.to_i) end context 'when new #update_time is later than original #solution_time' do it 'is updated based on the original #solution_time' do travel(2.hours) # time is frozen: if we don't travel forward, pre- and post-update values will be the same expect { article } .to change { ticket.reload.escalation_at.to_i } .to eq(4.hours.after(ticket.created_at).to_i) end end end end context 'when updated after an SLA has been added to the system' do before do ticket # create ticket sla # create sla end it 'is updated based on the new SLA’s #first_response_time' do expect { ticket.save! } .to change { ticket.reload.escalation_at.to_i }.from(0).to(1.hour.from_now.to_i) end end context 'when updated after all SLAs have been removed from the system' do before do sla # create sla ticket # create ticket sla.destroy end it 'is set to nil' do expect { ticket.save! } .to change { ticket.reload.escalation_at }.to(nil) end end end describe '#first_response_escalation_at' do before { travel_to(Time.current) } # freeze time let(:sla) { create(:sla, calendar: calendar, first_response_time: 60, update_time: 180, solution_time: 240) } let(:calendar) { create(:calendar, :'24/7') } context 'with no SLAs in the system' do it 'defaults to nil' do expect(ticket.first_response_escalation_at).to be(nil) end end context 'with an SLA in the system' do before { sla } # create sla it 'is set based on SLA’s #first_response_time' do expect(ticket.reload.first_response_escalation_at.to_i) .to eq(1.hour.from_now.to_i) end context 'after first agent’s response' do before { ticket } # create ticket let(:article) { create(:ticket_article, ticket: ticket, sender_name: 'Agent') } it 'does not change' do expect { article }.not_to change(ticket, :first_response_escalation_at) end end end end describe '#update_escalation_at' do before { travel_to(Time.current) } # freeze time let(:sla) { create(:sla, calendar: calendar, first_response_time: 60, update_time: 180, solution_time: 240) } let(:calendar) { create(:calendar, :'24/7') } context 'with no SLAs in the system' do it 'defaults to nil' do expect(ticket.update_escalation_at).to be(nil) end end context 'with an SLA in the system' do before { sla } # create sla it 'is set based on SLA’s #update_time' do expect(ticket.reload.update_escalation_at.to_i) .to eq(3.hours.from_now.to_i) end context 'after first agent’s response' do before { ticket } # create ticket let(:article) { create(:ticket_article, ticket: ticket, sender_name: 'Agent') } it 'is updated based on the SLA’s #update_time' do travel(1.minute) # time is frozen: if we don't travel forward, pre- and post-update values will be the same expect { article } .to change { ticket.reload.update_escalation_at.to_i } .to(3.hours.from_now.to_i) end end end end describe '#close_escalation_at' do before { travel_to(Time.current) } # freeze time let(:sla) { create(:sla, calendar: calendar, first_response_time: 60, update_time: 180, solution_time: 240) } let(:calendar) { create(:calendar, :'24/7') } context 'with no SLAs in the system' do it 'defaults to nil' do expect(ticket.close_escalation_at).to be(nil) end end context 'with an SLA in the system' do before { sla } # create sla it 'is set based on SLA’s #solution_time' do expect(ticket.reload.close_escalation_at.to_i) .to eq(4.hours.from_now.to_i) end context 'after first agent’s response' do before { ticket } # create ticket let(:article) { create(:ticket_article, ticket: ticket, sender_name: 'Agent') } it 'does not change' do expect { article }.not_to change(ticket, :close_escalation_at) end end end end end describe 'Associations:' do describe '#organization' do subject(:ticket) { build(:ticket, customer: customer, organization: nil) } let(:customer) { create(:customer, :with_org) } context 'on creation' do it 'automatically adopts the organization of its #customer' do expect { ticket.save } .to change(ticket, :organization).to(customer.organization) end end context 'on update of #customer.organization' do context 'to nil' do it 'automatically updates to #customer’s new value' do ticket.save expect { customer.update(organization: nil) } .to change { ticket.reload.organization }.to(nil) end end context 'to a different organization' do let(:new_org) { create(:organization) } it 'automatically updates to #customer’s new value' do ticket.save expect { customer.update(organization: new_org) } .to change { ticket.reload.organization }.to(new_org) end end end end end describe '.search' do shared_examples 'search permissions' do let(:group) { create(:group) } before do ticket end shared_examples 'permitted' do it 'finds Ticket' do expect( described_class.search(query: ticket.number, current_user: current_user).count ).to eq(1) end end shared_examples 'no permission' do it "doesn't find Ticket" do expect( described_class.search(query: ticket.number, current_user: current_user) ).to be_blank end end context 'Agent with Group access' do let(:ticket) do ticket = create(:ticket, group: group) create(:ticket_article, ticket: ticket) ticket end let(:current_user) { create(:agent, groups: [group]) } it_behaves_like 'permitted' end context 'when Agent is Customer of Ticket' do let(:ticket) do ticket = create(:ticket, customer: current_user) create(:ticket_article, ticket: ticket) ticket end let(:current_user) { create(:agent_and_customer) } it_behaves_like 'permitted' end context 'for Organization access' do let(:ticket) do ticket = create(:ticket, customer: customer) create(:ticket_article, ticket: ticket) ticket end let(:customer) { create(:customer, organization: organization) } context 'when Organization is shared' do let(:organization) { create(:organization, shared: true) } context 'for unrelated Agent' do let(:current_user) { create(:agent) } it_behaves_like 'no permission' end context 'for Agent in same Organization' do let(:current_user) { create(:agent_and_customer, organization: organization) } it_behaves_like 'permitted' end context 'for Customer of Ticket' do let(:current_user) { customer } it_behaves_like 'permitted' end end context 'when Organization is not shared' do let(:organization) { create(:organization, shared: false) } context 'for unrelated Agent' do let(:current_user) { create(:agent) } it_behaves_like 'no permission' end context 'for Agent in same Organization' do let(:current_user) { create(:agent_and_customer, organization: organization) } it_behaves_like 'no permission' end context 'for Customer of Ticket' do let(:current_user) { customer } it_behaves_like 'permitted' end end end end context 'with searchindex', searchindex: true do include_examples 'search permissions' do before do configure_elasticsearch(required: true, rebuild: true) end end end context 'without searchindex' do include_examples 'search permissions' end end describe 'Callbacks & Observers -' do describe 'NULL byte handling (via ChecksAttributeValuesAndLength concern):' do it 'removes them from title on creation, if necessary (postgres doesn’t like them)' do expect { create(:ticket, title: "some title \u0000 123") } .not_to raise_error end end describe 'XSS protection:' do subject(:ticket) { create(:ticket, title: title) } let(:title) { 'test 123 ' } it 'does not sanitize title' do expect(ticket.title).to eq(title) end end describe 'Cti::CallerId syncing:' do subject(:ticket) { build(:ticket) } before { allow(Cti::CallerId).to receive(:build) } it 'adds numbers in article bodies (via Cti::CallerId.build)' do expect(Cti::CallerId).to receive(:build).with(ticket) ticket.save Observer::Transaction.commit Scheduler.worker(true) end end describe 'Touching associations on update:' do subject(:ticket) { create(:ticket, customer: customer) } let(:customer) { create(:customer, organization: organization) } let(:organization) { create(:organization) } let(:other_customer) { create(:customer, organization: other_organization) } let(:other_organization) { create(:organization) } context 'on creation' do it 'touches its customer and his organization' do expect { ticket } .to change { customer.reload.updated_at } .and change { organization.reload.updated_at } end end context 'on destruction' do before { ticket } it 'touches its customer and his organization' do expect { ticket.destroy } .to change { customer.reload.updated_at } .and change { organization.reload.updated_at } end end context 'when customer association is changed' do it 'touches both old and new customer, and their organizations' do expect { ticket.update(customer: other_customer) } .to change { customer.reload.updated_at } .and change { organization.reload.updated_at } .and change { other_customer.reload.updated_at } .and change { other_organization.reload.updated_at } end end end describe 'Association & attachment management:' do it 'deletes all related ActivityStreams on destroy' do create_list(:activity_stream, 3, o: ticket) expect { ticket.destroy } .to change { ActivityStream.exists?(activity_stream_object_id: ObjectLookup.by_name('Ticket'), o_id: ticket.id) } .to(false) end it 'deletes all related Links on destroy' do create(:link, from: ticket, to: create(:ticket)) create(:link, from: create(:ticket), to: ticket) create(:link, from: ticket, to: create(:ticket)) expect { ticket.destroy } .to change { Link.where('link_object_source_value = :id OR link_object_target_value = :id', id: ticket.id).any? } .to(false) end it 'deletes all related Articles on destroy' do create_list(:ticket_article, 3, ticket: ticket) expect { ticket.destroy } .to change { Ticket::Article.exists?(ticket: ticket) } .to(false) end it 'deletes all related OnlineNotifications on destroy' do create_list(:online_notification, 3, o: ticket) expect { ticket.destroy } .to change { OnlineNotification.where(object_lookup_id: ObjectLookup.by_name('Ticket'), o_id: ticket.id).any? } .to(false) end it 'deletes all related Tags on destroy' do create_list(:tag, 3, o: ticket) expect { ticket.destroy } .to change { Tag.exists?(tag_object_id: Tag::Object.lookup(name: 'Ticket').id, o_id: ticket.id) } .to(false) end it 'deletes all related Histories on destroy' do create_list(:history, 3, o: ticket) expect { ticket.destroy } .to change { History.exists?(history_object_id: History::Object.lookup(name: 'Ticket').id, o_id: ticket.id) } .to(false) end it 'deletes all related Karma::ActivityLogs on destroy' do create_list(:'karma/activity_log', 3, o: ticket) expect { ticket.destroy } .to change { Karma::ActivityLog.exists?(object_lookup_id: ObjectLookup.by_name('Ticket'), o_id: ticket.id) } .to(false) end it 'deletes all related RecentViews on destroy' do create_list(:recent_view, 3, o: ticket) expect { ticket.destroy } .to change { RecentView.exists?(recent_view_object_id: ObjectLookup.by_name('Ticket'), o_id: ticket.id) } .to(false) end it 'destroys all related dependencies' do refs_known = { 'Ticket::Article' => { 'ticket_id'=>1 }, 'Ticket::TimeAccounting' => { 'ticket_id'=>1 }, 'Ticket::Flag' => { 'ticket_id'=>1 } } ticket = create(:ticket) article = create(:ticket_article, ticket: ticket) accounting = create(:ticket_time_accounting, ticket: ticket) flag = create(:ticket_flag, ticket: ticket) refs_ticket = Models.references('Ticket', ticket.id, true) expect(refs_ticket).to eq(refs_known) ticket.destroy expect { ticket.reload }.to raise_exception(ActiveRecord::RecordNotFound) expect { article.reload }.to raise_exception(ActiveRecord::RecordNotFound) expect { accounting.reload }.to raise_exception(ActiveRecord::RecordNotFound) expect { flag.reload }.to raise_exception(ActiveRecord::RecordNotFound) end context 'when ticket is generated from email (with attachments)' do subject(:ticket) { Channel::EmailParser.new.process({}, raw_email).first } let(:raw_email) { File.read(Rails.root.join('test/data/mail/mail001.box')) } it 'adds attachments to the Store{::File,::Provider::DB} tables' do expect { ticket } .to change(Store, :count).by(2) .and change { Store::File.count }.by(2) .and change { Store::Provider::DB.count }.by(2) end context 'and subsequently destroyed' do it 'deletes all related attachments' do ticket # create ticket expect { ticket.destroy } .to change(Store, :count).by(-2) .and change { Store::File.count }.by(-2) .and change { Store::Provider::DB.count }.by(-2) end end context 'and a duplicate ticket is generated from the same email' do before { ticket } # create ticket let(:duplicate) { Channel::EmailParser.new.process({}, raw_email).first } it 'adds duplicate attachments to the Store table only' do expect { duplicate } .to change(Store, :count).by(2) .and change { Store::File.count }.by(0) .and change { Store::Provider::DB.count }.by(0) end context 'when only the duplicate ticket is destroyed' do it 'deletes only the duplicate attachments' do duplicate # create ticket expect { duplicate.destroy } .to change(Store, :count).by(-2) .and change { Store::File.count }.by(0) .and change { Store::Provider::DB.count }.by(0) end it 'deletes all related attachments' do duplicate.destroy expect { ticket.destroy } .to change(Store, :count).by(-2) .and change { Store::File.count }.by(-2) .and change { Store::Provider::DB.count }.by(-2) end end end end end describe 'Ticket lifecycle order-of-operations:' do subject!(:ticket) { create(:ticket) } let!(:agent) { create(:agent, groups: [group]) } let(:group) { create(:group) } before do create( :trigger, condition: { 'ticket.action' => { 'operator' => 'is', 'value' => 'create' } }, perform: { 'ticket.group_id' => { 'value' => group.id } } ) end it 'fires triggers before new ticket notifications are sent' do expect { Observer::Transaction.commit } .to change { ticket.reload.group }.to(group) expect { Scheduler.worker(true) } .to change { NotificationFactory::Mailer.already_sent?(ticket, agent, 'email') }.to(1) end end end end