Nulo/gitea
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Activity

Set the initial commit status to Success otherwise it will always be Pending (#10317) (#10318)

Browse source 
Backport #10317

The commit status code has a bug whereby setting the initial status to Pending means you can never have the status of Success - it should be set to Success.
This commit is contained in:
zeripath 2020-02-17 20:50:59 +00:00 committed by GitHub
parent 4529a262c0
commit 117dcf1c02
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/pull/commit_status.go
View file

@ -23,7 +23,7 @@ func MergeRequiredContextsCommitStatus(commitStatuses []*models.CommitStatus, re
return structs.CommitStatusSuccess return structs.CommitStatusSuccess
} }
var returnedStatus = structs.CommitStatusPending var returnedStatus = structs.CommitStatusSuccess
for _, ctx := range requiredContexts { for _, ctx := range requiredContexts {
var targetStatus structs.CommitStatusState var targetStatus structs.CommitStatusState
for _, commitStatus := range commitStatuses { for _, commitStatus := range commitStatuses {