Sutty/trabajo-afectivo
5
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Refactoring: Migrate ticket_article_time_accounting_test to RSpec

Browse source
This commit is contained in:
Ryan Lue 2019-02-15 13:00:27 +08:00 committed by Martin Edenhofer
parent 94536705e6
commit 31adff6a42
3 changed files with 32 additions and 118 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
spec/factories/ticket/time_accounting.rb
View file

@ -1,7 +1,11 @@
FactoryBot.define do
factory :ticket_time_accounting, class: Ticket::TimeAccounting do
factory :'ticket/time_accounting', aliases: %i[ticket_time_accounting] do
ticket
time_unit { rand(100) }
created_by_id 1
trait :for_article do
ticket_article { create(:'ticket/article', ticket: ticket) }
end
end
end

27
spec/models/ticket/time_accounting_spec.rb Normal file
View file

@ -0,0 +1,27 @@
require 'rails_helper'
RSpec.describe Ticket::TimeAccounting, type: :model do
subject(:time_accounting) { create(:'ticket/time_accounting') }
describe 'Associations:' do
describe '#ticket_article' do
subject!(:time_accounting) { create(:'ticket/time_accounting', :for_article) }
context 'when destroyed' do
it 'destroys self' do
expect { time_accounting.ticket_article.destroy }
.to change { time_accounting.persisted? }.to(false)
.and change { Ticket::TimeAccounting.count }.by(-1)
end
it 'does not destroy other TimeAccountings for same ticket' do
create(:'ticket/time_accounting', ticket: time_accounting.ticket)
create(:'ticket/time_accounting', :for_article, ticket: time_accounting.ticket)
expect { time_accounting.ticket_article.destroy }
.to change { Ticket::TimeAccounting.count }.by(-1)
end
end
end
end
end

117
test/unit/ticket_article_time_accouting_test.rb
View file

@ -1,117 +0,0 @@
require 'test_helper'
class TicketArticleTimeAccoutingTest < ActiveSupport::TestCase
test 'destroy dependent time accounting for ticket and article' do
ticket_test = Ticket.create(
title: 'com test 1',
group: Group.lookup(name: 'Users'),
customer_id: 2,
state: Ticket::State.lookup(name: 'new'),
priority: Ticket::Priority.lookup(name: '2 normal'),
updated_by_id: 1,
created_by_id: 1,
)
assert(ticket_test, 'ticket created')
article_test1 = Ticket::Article.create(
ticket_id: ticket_test.id,
from: 'some_customer_com-1@example.com',
to: 'some_zammad_com-1@example.com',
subject: 'com test 1',
message_id: 'some@id_com_1',
body: 'some message 123',
internal: false,
sender: Ticket::Article::Sender.find_by(name: 'Customer'),
type: Ticket::Article::Type.find_by(name: 'email'),
updated_by_id: 1,
created_by_id: 1,
)
Ticket::TimeAccounting.create!(
ticket_id: ticket_test.id,
ticket_article_id: article_test1.id,
time_unit: 10,
created_by_id: 1,
)
article_test2 = Ticket::Article.create(
ticket_id: ticket_test.id,
from: 'some_customer_com-1@example.com',
to: 'some_zammad_com-1@example.com',
subject: 'com test 1',
message_id: 'some@id_com_1',
body: 'some message 123',
internal: false,
sender: Ticket::Article::Sender.find_by(name: 'Customer'),
type: Ticket::Article::Type.find_by(name: 'email'),
updated_by_id: 1,
created_by_id: 1,
)
Ticket::TimeAccounting.create!(
ticket_id: ticket_test.id,
ticket_article_id: article_test2.id,
time_unit: 10,
created_by_id: 1,
)
article_test3 = Ticket::Article.create(
ticket_id: ticket_test.id,
from: 'some_customer_com-1@example.com',
to: 'some_zammad_com-1@example.com',
subject: 'com test 1',
message_id: 'some@id_com_1',
body: 'some message 123',
internal: false,
sender: Ticket::Article::Sender.find_by(name: 'Customer'),
type: Ticket::Article::Type.find_by(name: 'email'),
updated_by_id: 1,
created_by_id: 1,
)
Ticket::TimeAccounting.create!(
ticket_id: ticket_test.id,
ticket_article_id: article_test3.id,
time_unit: 10,
created_by_id: 1,
)
Ticket::TimeAccounting.create!(
ticket_id: ticket_test.id,
time_unit: 10,
created_by_id: 1,
)
time_accouting_list = Ticket::TimeAccounting.where(
ticket_id: ticket_test.id,
)
found = time_accouting_list.select { |t| t.ticket_article_id.in?([article_test1.id, article_test2.id, article_test3.id]) }
assert_equal(3, found.count)
article_test1.destroy
time_accouting_list.reload
found = time_accouting_list.select { |t| t.ticket_article_id.in?([article_test1.id, article_test2.id, article_test3.id]) }
assert_equal(2, found.count)
article_test2.destroy
time_accouting_list.reload
found = time_accouting_list.select { |t| t.ticket_article_id.in?([article_test1.id, article_test2.id, article_test3.id]) }
assert_equal(1, found.count)
article_test3.destroy
time_accouting_list.reload
found = time_accouting_list.select { |t| t.ticket_article_id.in?([article_test1.id, article_test2.id, article_test3.id]) }
assert_equal(0, found.count)
# one accouting left for the ticket only
assert_equal(1, time_accouting_list.count)
ticket_test.destroy
time_accouting_list.reload
assert_equal(0, time_accouting_list.count)
end
end