Improved error handling.

This commit is contained in:
Martin Edenhofer 2014-07-14 09:39:09 +02:00
parent 3aa22ceb10
commit 326c0903f1

View file

@ -34,6 +34,7 @@ class Observer::Ticket::Notification < ActiveRecord::Observer
next if !ticket next if !ticket
article = ticket.articles[-1] article = ticket.articles[-1]
next if !article
else else
raise "unknown object for notification #{event[:name]}" raise "unknown object for notification #{event[:name]}"
end end
@ -237,17 +238,13 @@ class Observer::Ticket::Notification < ActiveRecord::Observer
# add history record # add history record
if recipient_list != '' if recipient_list != ''
created_by_id = 1
if article && article.created_by_id
created_by_id = article.created_by_id
end
History.add( History.add(
:o_id => ticket.id, :o_id => ticket.id,
:history_type => 'notification', :history_type => 'notification',
:history_object => 'Ticket', :history_object => 'Ticket',
:value_from => notification_subject, :value_from => notification_subject,
:value_to => recipient_list, :value_to => recipient_list,
:created_by_id => created_by_id :created_by_id => article.created_by_id || 1
) )
end end
end end