using constants instead of literals

app/controllers/ticket_states_controller.rb

@@ -15,19 +15,19 @@ class TicketStatesController < ApplicationController
 
   # POST /ticket_states
   def create
-    return if deny_if_not_role('Admin')
+    return if deny_if_not_role(Z_ROLENAME_ADMIN)
     model_create_render(Ticket::State, params)
   end
 
   # PUT /ticket_states/1
   def update
-    return if deny_if_not_role('Admin')
+    return if deny_if_not_role(Z_ROLENAME_ADMIN)
     model_update_render(Ticket::State, params)
   end
 
   # DELETE /ticket_states/1
   def destroy
-    return if deny_if_not_role('Admin')
+    return if deny_if_not_role(Z_ROLENAME_ADMIN)
     model_destory_render(Ticket::State, params)
   end
 end

config/initializers/zammad_constants.rb

@@ -0,0 +1,7 @@
+# Copyright (C) 2014 Zammad Foundation, http://zammad-foundation.org/
+
+# Prefix all zammad constants w/ Z_
+
+# Prefix all rolenames with Z_ROLENAME
+Z_ROLENAME_ADMIN = 'Admin'
+